Skip to content

Define Rng #1690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 23, 2022
Merged

Define Rng #1690

merged 5 commits into from
Jan 23, 2022

Conversation

Akshobhya1234
Copy link
Contributor

Define Rng as mentioned in #1687

Should we call it RingWithoutOne or Rng?

@Taneb
Copy link
Member

Taneb commented Jan 16, 2022

It should definitely be called RingWithoutOne for consistency with the other definitions (e.g. we have Semiring, not Rig), and that it's clearer what it means.

@MatthewDaggitt MatthewDaggitt added this to the v2.0 milestone Jan 16, 2022
MatthewDaggitt
MatthewDaggitt reviewed Jan 16, 2022
View reviewed changes
@MatthewDaggitt MatthewDaggitt merged commit 4e934c6 into agda:master Jan 23, 2022
@MatthewDaggitt MatthewDaggitt linked an issue Feb 3, 2022 that may be closed by this pull request
Add IsRingWithoutOne and RingWithoutOne #1687
Closed
@andreasabel andreasabel mentioned this pull request Jul 24, 2023
Merged
@andreasabel andreasabel mentioned this pull request Aug 27, 2023
Merged
@andreasabel andreasabel mentioned this pull request Oct 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatthewDaggitt MatthewDaggitt MatthewDaggitt left review comments

Assignees
No one assigned
Labels
addition
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

Add IsRingWithoutOne and RingWithoutOne
3 participants
@Akshobhya1234 @Taneb @MatthewDaggitt