-
Notifications
You must be signed in to change notification settings - Fork 251
Add padRight
and truncate
to Data.Vec
, and prove some properties
#1640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In Bounded we have:
so we should probably stick to that naming convention. |
Yeah, that seems reasonable! Should we mark this as a breaking change then? If you import |
pad
and truncate
to Data.Vec
, and prove some propertiespadRight
and truncate
to Data.Vec
, and prove some properties
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great PR! A few minor cosmetic comments.
It's a good thought, but we add dozens of duplicated function names throughout the library every release so we tend not to. Also recent versions of Agda tends to give reasonable error messages for clashes so it's not too hard to debug the problem. |
@TOTBWF any chance you have the time to make the minor changes from the reviews and then I'll merge this in? |
Sorry, I've been quite busy recently and this fell off my radar! |
Thanks @gallais! |
Patch Description
This PR adds the following functions to
Data.Vec.Base
It also proves some properties of these two functions.