Skip to content

make sidebar nav maintain query string params #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2025
Merged

make sidebar nav maintain query string params #649

merged 1 commit into from
Nov 6, 2025

Conversation

@maxkorp
Copy link
Contributor

@maxkorp maxkorp commented Nov 6, 2025

When you navigate around with the sidebar, the dojo loses query string params like frameworkPicker=false

This fixes that

@maxkorp maxkorp merged commit b5df850 into main Nov 6, 2025
17 checks passed
@maxkorp maxkorp deleted the max/dojo-maintain-params branch November 6, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mme mme Awaiting requested review from mme mme is a code owner

@ranst91 ranst91 Awaiting requested review from ranst91 ranst91 is a code owner

@ataibarkai ataibarkai Awaiting requested review from ataibarkai ataibarkai is a code owner

@tylerslaton tylerslaton Awaiting requested review from tylerslaton tylerslaton is a code owner

@NathanTarbert NathanTarbert Awaiting requested review from NathanTarbert NathanTarbert is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maxkorp