[GH-#134] Api functions protected by key, to control node #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t matches the one from env to call Miner functions
cytadela8
approved these changes
Dec 14, 2017
There was a problem hiding this comment.
Looks good!
If we would like to be more security concerned if env_authorization == header_authorization do creates a possibility of a timing attack where attacker guesses the env_authorization one byte at a time due to the fact the comparison is not constant time. But such problems are not our concern for now. eg. In future the private API will be only available locally.
thepiwo
reviewed
Dec 15, 2017
apps/aecore/config/dev.exs
Outdated
| env -> env | ||
| end | ||
|
|
||
| # config :aecore, :authorization, |
thepiwo
approved these changes
Dec 15, 2017
|
@meivantodorov @andonov can you approve? |
meivantodorov
approved these changes
Dec 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #134