[GH-#85] Validation for difficulty target #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nedelcho-delchev-tues
requested review from
andonov,
cytadela8,
meivantodorov and
thepiwo
thepiwo
reviewed
Nov 21, 2017
| catch | ||
| {:error, _message} -> | ||
| Logger.error(fn -> | ||
| "Failed to mine block" |
There was a problem hiding this comment.
can you log the message here as well?
|
Not done yet, don't merge |
thepiwo
approved these changes
Nov 21, 2017
- do correct check in miner, differing from next calculation
|
The issue is fixed, you can review it @meivantodorov, @cytadela8, @andonov. |
andonov
approved these changes
Nov 21, 2017
cytadela8
approved these changes
Nov 22, 2017
| else | ||
| [_ | something] = Chain.get_blocks(latest_block_hash, Difficulty.get_number_of_blocks() + 1) | ||
| something | ||
| end |
There was a problem hiding this comment.
I trust this logic is correct. it looks weird
There was a problem hiding this comment.
@nedelcho-delchev-tues maybe we can optimize this somehow to be better readable and add some comment
There was a problem hiding this comment.
I pushed a change directly to master, you can see if it is better and more understandable.
@cytadela8
meivantodorov
approved these changes
Nov 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #85