[GH-115] Peers sync #123
Merged
[GH-115] Peers sync #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please check and advice about code style. This is my first contribution so I probably violated some established rules. |
thepiwo
reviewed
Nov 11, 2017
| else | ||
| case check_peer(uri, own_nonce) do | ||
| {:ok, info} -> | ||
| if map_size(peers) < @peers_max_count |
There was a problem hiding this comment.
can we refactor this if condition into a function, to give it a name
thepiwo
approved these changes
Nov 11, 2017
|
code style is good so far, we have no specific rules yet |
cytadela8
commented
Nov 11, 2017
| end | ||
| end | ||
|
|
||
| defp should_a_peer_be_added peers_count do |
There was a problem hiding this comment.
@thepiwo Is this what you thought of?
andonov
approved these changes
Nov 12, 2017
meivantodorov
approved these changes
Nov 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves following problems:
peers_target_countpeers we add random peers from peers known by peers we know. (We request peers list from peers we know and add random peers from that list)peers_target_countpeers we remove one randomly every "sync loop".Stuff missing for ready peers sync:
This replaces #120
This closes #115