GH-90 endpoint to get transactions from pool concerning account #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thepiwo
reviewed
Oct 30, 2017
| :info -> | ||
| response = Poison.decode!(body, keys: :atoms!) | ||
| {:ok, response} | ||
| :peers -> |
There was a problem hiding this comment.
why is :peers and :balance removed?
There was a problem hiding this comment.
:peers and :balance will be handled by the default json_response()
|
can you remove the compiler warnings, as well? |
|
can you add a test as well for getting an existinng tx from the pool and one where there is none transaction? |
thepiwo
approved these changes
Oct 30, 2017
andonov
approved these changes
Oct 30, 2017
meivantodorov
approved these changes
Oct 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #90