forked from vuestorefront/magento2
-
Notifications
You must be signed in to change notification settings - Fork 0
Recaptcha #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aelmizeb
wants to merge
66
commits into
develop
Choose a base branch
from
recaptcha
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import { FetchResult } from '@apollo/client/core'; | ||
| import { CustomQuery } from '@vue-storefront/core'; | ||
| import { GraphQLError } from 'graphql'; | ||
| import recaptchaHelper from '../../helpers/recaptcha/recaptchaHelper'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename the fonction as recaptchaValidator maybe ?
* fix(theme): M2-25 fix links to catch current locale * Apply suggestions from code review Co-authored-by: Heitor Ramon Ribeiro <[email protected]> * test(test-utils): added localePath global mock to the test-utils Co-authored-by: Bartosz Herba <[email protected]> Co-authored-by: Heitor Ramon Ribeiro <[email protected]> Co-authored-by: Marcin Kwiatkowski <[email protected]>
* feat(middleware): added i18n route middleware closes vuestorefront#378 * refactor(middleware): i18n middleware: adjustements
…#416) Co-authored-by: Bartosz Herba <[email protected]>
…and explicit (vuestorefront#418) Co-authored-by: Bartosz Herba <[email protected]>
* refactor(eslint): updated dependencies - Updated `eslint-plugin-unicorn` to `40.0.0` * refactor(eslint-import): updated dependencies - Updated `eslint-plugin-import` to `2.25.4` * refactor(eslint-jest): updated dependencies - Updated `eslint-plugin-jest` to `25.3.4` * refactor(eslint-typescript): updated dependencies - Updated `@typescript-eslint/eslint-plugin` to `5.9.1` - Updated `@typescript-eslint/parser` to `5.9.1` * refactor(eslint-vue): updated dependencies - Updated `eslint-plugin-vue` to `8.3.0` * refactor(api-client): updated dependencies - Updated `@apollo/client` to `3.5.7` - Updated `dotenv` to `12.0.1` * refactor(theme): updated dependencies - Updated `@babel/core` to `7.16.7` - Updated `babel-jest` to `27.4.6` - Updated `cypress` to `9.2.1` - Updated `dotenv` to `12.0.1` - Updated `jest` to `27.4.7` - Updated `jest-environment-jsdom` to `27.4.6` - Updated `lint-staged` to `12.1.7` - Updated `mocha` to `9.1.4` - Updated `npm-check-updates` to `12.1.0` - Updated `ts-jest` to `27.1.3` * refactor: updated dependencies - Updated `@babel/core` to `7.16.7` - Updated `@babel/plugin-proposal-private-methods` to `7.16.7` - Updated `@commitlint/cli` to `16.0.2` - Updated `@commitlint/config-conventional` to `16.0.0` - Updated `@commitlint/config-lerna-scopes` to `16.0.0` - Updated `@graphql-codegen/cli` to `2.3.1` - Updated `@graphql-codegen/typescript` to `2.4.2` - Updated `@graphql-codegen/typescript-operations` to `2.2.2` - Updated `@graphql-tools/utils` to `8.6.1` - Updated `@rollup/plugin-node-resolve` to `13.1.3` - Updated `@types/jest` to `27.4.0` - Updated `@types/node` to `17.0.8` - Updated `@typescript-eslint/parser` to `5.9.1` - Updated `@vue/eslint-config-typescript` to `10.0.0` - Updated `eslin` to `8.6.0` - Updated `jest` to `27.4.7` - Updated `lint-staged` to `12.1.7` - Updated `npm-check-updates` to `12.1.0` - Updated `rollup` to `2.64.0` - Updated `shx` to `0.3.4` - Updated `ts-jest` to `27.1.3```
…uestorefront#424) Co-authored-by: Bartosz Herba <[email protected]>
…torefront#419) * test(composables): added jest config * tests(composables): rewritten test + fix in productGetter * tests(composables): updated configuration in jest.config.js * tests(api-client): added tests for api-client + move general config to jest.base.config.js * tests(api-client): added jest configuration + simple test * chore: removed jest-environment-jsdom-sixteen * tests(theme): reverted back and removed jest.base.config.json * test(composables): reverted back and removed jest.base.config.json * test(api-client): reverted back and removed jest.base.config.json * chore: removed jest.base.config.json Co-authored-by: Marcin Kwiatkowski <[email protected]>
…front#423) Co-authored-by: Bartosz Herba <[email protected]>
…ront#404) * fix(theme): out of stock product will no longer break cart * fix(theme): remove cart load from layout * docs(theme): update tests for CartSidebar Co-authored-by: Bartosz Herba <[email protected]>
…storefront#421)" (vuestorefront#426) This reverts commit fbb1598.
vuestorefront#425) * refactor(i18n): changed i18n middleware to plugin and fix store switcher by url issues * refactor: cR fixes for i18n
… url (vuestorefront#431) * refactor(i18n): changed i18n middleware to plugin and fix store switcher by url issues * refactor: cR fixes for i18n * refactor(composables): added `ConfigState` to export API * chore: updated yarn.lock * refactor(theme): updated i18n middleware to fix URL redirect * docs: updated API-Extractor Co-authored-by: Marcin Kwiatkowski <[email protected]>
…ient (vuestorefront#429) Co-authored-by: Bartosz Herba <[email protected]>
* fix(theme): disabled checkbox on login-modal * feat(theme): log customer out when customer-token is expired * feat: added token expired notification, clear cart and customer token when customer is not logged in * feat: logged out notification * refactor: removed console log * refactor: added improvements for token-expired plugin, added unit tests * refactor: changed log out notification message * test: fixed token-expired plugin test * test: added cookies mock to test-utils Co-authored-by: Marcin Kwiatkowski <[email protected]>
…refront#430) * refactor(theme): enables currency switcher on TopBar.vue * refactor(theme): add safe checking on Currency Selector
Co-authored-by: Bartosz Herba <[email protected]>
…ring development (vuestorefront#443) Updated the nuxt.config.js by increasing the enforceSizeThreshold and removing configuration properties
…#450) Co-authored-by: Bartosz Herba <[email protected]>
* fix(theme): solve currency change issue * docs(theme): add currency formatting plugin information * test(theme): add UT for plugin and formatCurrency helper * refactor(fcplugin): change the logic responsible for resolving locale value Co-authored-by: Bartosz Herba <[email protected]>
* Fix useFacet(...) customQuery implemention (vuestorefront#413) * chore: release 1.0.0-rc.5.3 (vuestorefront#437) * chore: add gitflow actions (vuestorefront#379) * chore: added base gitflow actions * chore: added base gitflow actions * chore: fixed versioning process * docs: added roadmap to the docs (vuestorefront#380) closes vuestorefront#323 * fix(theme): refactor and fix store switcher (vuestorefront#383) - update nuxt.config.js to handle de translation - fix issue with flag icon vuestorefront#362 - refactor store switcher component - add store name next to the language icon flag - add translation info in docs Co-authored-by: Bartosz Herba <[email protected]> * fix(theme): fix preselection sort order when query param is available (vuestorefront#385) Co-authored-by: Bartosz Herba <[email protected]> * fix: broken cart after placing order as guest (vuestorefront#386) * fix(theme): passing the email instead of the user-object for creating a guest-cart * fix(composables): remove empty params in array, fails on Magento * test(theme): updated test for attaching guest email address to cart * Update packages/composables/src/composables/useShipping/index.ts Co-authored-by: Heitor Ramon Ribeiro <[email protected]> Co-authored-by: Marcin Kwiatkowski <[email protected]> Co-authored-by: Heitor Ramon Ribeiro <[email protected]> * fix(theme): fix flashing category page (vuestorefront#387) Co-authored-by: Bartosz Herba <[email protected]> * fix(theme): fix flashing category page (vuestorefront#388) Co-authored-by: Bartosz Herba <[email protected]> * fix: default billing information does not appear on address (vuestorefront#382) * fix(theme): added badge for default-shipping and default-sbilling address * fix(composables): sort addresses, put default shipping and billing address to top * fix(theme): default billing and shipping text can be translated * chore(theme): added translations * fix(composables): removed console.log * chore: upgraded vsf core to 2.5.4 (vuestorefront#389) * chore: updated VSF core version to 2.5.4 * build: updated test GH action * fix(composables): update url resolver clearing patter to remove locale prefix (vuestorefront#390) Co-authored-by: Bartosz Herba <[email protected]> * fix(theme): fix links to catch current locale (vuestorefront#391) * fix(theme): M2-25 fix links to catch current locale * Apply suggestions from code review Co-authored-by: Heitor Ramon Ribeiro <[email protected]> * test(test-utils): added localePath global mock to the test-utils Co-authored-by: Bartosz Herba <[email protected]> Co-authored-by: Heitor Ramon Ribeiro <[email protected]> Co-authored-by: Marcin Kwiatkowski <[email protected]> * style(theme): aligned titles in my account menu (vuestorefront#400) * feat(middleware): added i18n route middleware (vuestorefront#408) * feat(middleware): added i18n route middleware closes vuestorefront#378 * refactor(middleware): i18n middleware: adjustements * fix(theme): update localisation for all :link bindings (vuestorefront#416) Co-authored-by: Bartosz Herba <[email protected]> * docs(theme): update custom queries documentation to be more friendly and explicit (vuestorefront#418) Co-authored-by: Bartosz Herba <[email protected]> * chore(theme): removed html-validator (vuestorefront#414) * refactor: update dependencies (vuestorefront#420) * refactor(eslint): updated dependencies - Updated `eslint-plugin-unicorn` to `40.0.0` * refactor(eslint-import): updated dependencies - Updated `eslint-plugin-import` to `2.25.4` * refactor(eslint-jest): updated dependencies - Updated `eslint-plugin-jest` to `25.3.4` * refactor(eslint-typescript): updated dependencies - Updated `@typescript-eslint/eslint-plugin` to `5.9.1` - Updated `@typescript-eslint/parser` to `5.9.1` * refactor(eslint-vue): updated dependencies - Updated `eslint-plugin-vue` to `8.3.0` * refactor(api-client): updated dependencies - Updated `@apollo/client` to `3.5.7` - Updated `dotenv` to `12.0.1` * refactor(theme): updated dependencies - Updated `@babel/core` to `7.16.7` - Updated `babel-jest` to `27.4.6` - Updated `cypress` to `9.2.1` - Updated `dotenv` to `12.0.1` - Updated `jest` to `27.4.7` - Updated `jest-environment-jsdom` to `27.4.6` - Updated `lint-staged` to `12.1.7` - Updated `mocha` to `9.1.4` - Updated `npm-check-updates` to `12.1.0` - Updated `ts-jest` to `27.1.3` * refactor: updated dependencies - Updated `@babel/core` to `7.16.7` - Updated `@babel/plugin-proposal-private-methods` to `7.16.7` - Updated `@commitlint/cli` to `16.0.2` - Updated `@commitlint/config-conventional` to `16.0.0` - Updated `@commitlint/config-lerna-scopes` to `16.0.0` - Updated `@graphql-codegen/cli` to `2.3.1` - Updated `@graphql-codegen/typescript` to `2.4.2` - Updated `@graphql-codegen/typescript-operations` to `2.2.2` - Updated `@graphql-tools/utils` to `8.6.1` - Updated `@rollup/plugin-node-resolve` to `13.1.3` - Updated `@types/jest` to `27.4.0` - Updated `@types/node` to `17.0.8` - Updated `@typescript-eslint/parser` to `5.9.1` - Updated `@vue/eslint-config-typescript` to `10.0.0` - Updated `eslin` to `8.6.0` - Updated `jest` to `27.4.7` - Updated `lint-staged` to `12.1.7` - Updated `npm-check-updates` to `12.1.0` - Updated `rollup` to `2.64.0` - Updated `shx` to `0.3.4` - Updated `ts-jest` to `27.1.3``` * refactor(theme): enables currency switcher on TopBar.vue (vuestorefront#421) * fix(theme): fix 404 issue when redirecting to address details page (vuestorefront#424) Co-authored-by: Bartosz Herba <[email protected]> * test: scaffold unit tests in composables and api client package (vuestorefront#419) * test(composables): added jest config * tests(composables): rewritten test + fix in productGetter * tests(composables): updated configuration in jest.config.js * tests(api-client): added tests for api-client + move general config to jest.base.config.js * tests(api-client): added jest configuration + simple test * chore: removed jest-environment-jsdom-sixteen * tests(theme): reverted back and removed jest.base.config.json * test(composables): reverted back and removed jest.base.config.json * test(api-client): reverted back and removed jest.base.config.json * chore: removed jest.base.config.json Co-authored-by: Marcin Kwiatkowski <[email protected]> * fix(theme): fix disappearing category sidebar filter change (vuestorefront#423) Co-authored-by: Bartosz Herba <[email protected]> * fix(theme): out of stock product will no longer break cart (vuestorefront#404) * fix(theme): out of stock product will no longer break cart * fix(theme): remove cart load from layout * docs(theme): update tests for CartSidebar Co-authored-by: Bartosz Herba <[email protected]> * Revert "refactor(theme): enables currency switcher on TopBar.vue (vuestorefront#421)" (vuestorefront#426) This reverts commit fbb1598. * refactor(i18n): changed i18n middleware to plugin and fix store switc… (vuestorefront#425) * refactor(i18n): changed i18n middleware to plugin and fix store switcher by url issues * refactor: cR fixes for i18n * refactor(theme): changed i18n midl. to plugin & fix store switcher by url (vuestorefront#431) * refactor(i18n): changed i18n middleware to plugin and fix store switcher by url issues * refactor: cR fixes for i18n * refactor(composables): added `ConfigState` to export API * chore: updated yarn.lock * refactor(theme): updated i18n middleware to fix URL redirect * docs: updated API-Extractor Co-authored-by: Marcin Kwiatkowski <[email protected]> * fix(api-client): update default mutation error handling for apollo client (vuestorefront#429) Co-authored-by: Bartosz Herba <[email protected]> * fix: expired user token (vuestorefront#392) * fix(theme): disabled checkbox on login-modal * feat(theme): log customer out when customer-token is expired * feat: added token expired notification, clear cart and customer token when customer is not logged in * feat: logged out notification * refactor: removed console log * refactor: added improvements for token-expired plugin, added unit tests * refactor: changed log out notification message * test: fixed token-expired plugin test * test: added cookies mock to test-utils Co-authored-by: Marcin Kwiatkowski <[email protected]> * refactor(theme): enable the currency switcher on `TopBar.vue` (vuestorefront#430) * refactor(theme): enables currency switcher on TopBar.vue * refactor(theme): add safe checking on Currency Selector * Fix useFacet(...) customQuery implemention (vuestorefront#413) * chore: updated version number to rc.5.3, updated yarn.lock, fixed cloud action * fix(theme): update localisation for all :link bindings (vuestorefront#449) Co-authored-by: Bartosz Herba <[email protected]> Co-authored-by: Heitor Ramon Ribeiro <[email protected]> Co-authored-by: Bartosz Herba <[email protected]> Co-authored-by: Bartosz Herba <[email protected]> Co-authored-by: Kevin Gorjan <[email protected]> Co-authored-by: Aliaaaam <[email protected]> Co-authored-by: Aliaaaam <[email protected]> Co-authored-by: Heitor Ramon Ribeiro <[email protected]> Co-authored-by: Bartosz Herba <[email protected]> Co-authored-by: Bartosz Herba <[email protected]> Co-authored-by: Kevin Gorjan <[email protected]>
…t#456) Co-authored-by: Bartosz Herba <[email protected]>
) Co-authored-by: Bartosz Herba <[email protected]>
… default currency fallback (vuestorefront#460) Co-authored-by: Bartosz Herba <[email protected]>
…configurable variants data (vuestorefront#461) Co-authored-by: Bartosz Herba <[email protected]>
c479acf to
2344eda
Compare
…torefront#496) * fix(composables): re-calculate cart when changing shipping-method * fix(theme): removed cache-id for retrieving shipping methods Cache id is removed because it retrieves the cached shipping methods. But when the address changes, it can be that the price of shipping methods need to be updated * chore: updated yarn.lock * fix(theme): redirect to home when accessing checkout if cart is empty * fix(theme): fixed hydration issue moved logic from SSR to onMounted to fix hydration difference
52eb770 to
27dacbd
Compare
Co-authored-by: Bartosz Herba <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: