Truncated element #4125
Merged
Truncated element #4125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Contributor
Lighthouse scores
What is this?Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on Transfer Size
Request Count
|
Westbrook
reviewed
Mar 5, 2024
Contributor
Westbrook
left a comment
Westbrook
left a comment
There was a problem hiding this comment.
There are a couple of interactions that require testing before this code meets the higher requirements of this library, see: https://output.circle-artifacts.com/output/job/90cd7104-b24e-4b7d-ae41-865a34e8dceb/artifacts/0/coverage/lcov-report/tools/truncated/src/Truncated.ts.html
Contributor
|
Can you catch this up to |
AndreiBaicu26
force-pushed
the
abaicu/truncated
branch
from
8822146 to
a3a6350
Compare
Contributor
Tachometer resultsCurrently, no packages are changed by this PR... |
AndreiBaicu26
added a commit
that referenced
this pull request
Mar 8, 2024
This reverts commit 82aca36.
AndreiBaicu26
added a commit
that referenced
this pull request
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To succesfully implement the Breadcrumbs component we would require the truncated element from UEC. We copied the component in SWC so we do not create a new dependency to UEC.
Related issue(s)
#4100
How has this been tested?
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.