refactor: move hover persiting code into "stack" from "trigger" #2612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lazd
approved these changes
Sep 23, 2022
Comment on lines
+595
to
+596
| !event.composedPath().includes(overlay.trigger) || | ||
| overlay.interaction !== 'hover' |
Member
There was a problem hiding this comment.
Perfect. This should keep overlays open that are in the same path (i.e. an open modal that has a click overlay), and it should keep hover overlays open as well (they go away when you remove hover). NAILED IT!
najikahalsema
approved these changes
Sep 23, 2022
Member
najikahalsema
left a comment
najikahalsema
left a comment
There was a problem hiding this comment.
Larry beat me to it! Great work!
Contributor
Tachometer resultsChromeaction-bar permalink
action-menu permalink
menu permalink
overlay permalink
picker permalink
popover permalink
split-button permalink
tooltip permalink
Firefoxaction-bar permalink
action-menu permalink
menu permalink
overlay permalink
picker permalink
popover permalink
split-button permalink
tooltip permalink
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a
hoveroverlay is open, if there is noclickoverlay content associated to itstriggerit should persist when clicking on thetrigger.Move logic for making this true out of the
overlay-triggerelement, and into theoverlay-stackso that it doesn't cause unexpected side effects and can be leveraged by the entire overlay API.Added bonus, deduplicate the sync and async test code.
Related issue(s)
How has this been tested?
hovercontent is still available at the end of the workflow.Types of changes
Checklist