docs(overlay): add instructions on styling overlay content #1383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Westbrook
commented
Apr 15, 2021
| } | ||
| customElements.define('docs-component', ComponentElement); | ||
|
|
||
| class StyledElement extends HTMLElement { |
Contributor
Author
There was a problem hiding this comment.
The code sample in the Docs are copyable, but not runnable inline, so the definition needs to actually be set here.
aashritandon92
previously approved these changes
Apr 16, 2021
Contributor
aashritandon92
left a comment
aashritandon92
left a comment
There was a problem hiding this comment.
Looks good to me!
packages/overlay/overlay-trigger.md
Outdated
|
|
||
| ```html | ||
| <overlay-trigger placement="top-start"> | ||
| <button slot="trigger">Trigger Element</button> |
Contributor
There was a problem hiding this comment.
Just wondering, was the usage of HTML button intentional, since rest of the document uses sp-button
Contributor
Author
There was a problem hiding this comment.
Good question! I was thinking this helped reduce the perception of "magic" here so that readers could focus on the [slot="click-content"] element, but maybe you bringing this up shows that I was mistaken and it should be sp-button for uniformity?
Contributor
There was a problem hiding this comment.
Yeah, sp-button would be better in my opinion.
Westbrook
force-pushed
the
westbrook/overlay-styles
branch
from
038488e to
103c69b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Outline style requirements for content that is thrown into an overlay.
PTAL: https://westbrook-overlay-styles--spectrum-web-components.netlify.app/components/overlay-trigger
Related Issue
fixes #1267
Motivation and Context
Make adopting out elements as easy as possible.
Screenshots (if appropriate):
Types of changes
Checklist: