fix(overlay): allow overlay-trigger to declaratively open overlay content #1294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Westbrook
force-pushed
the
westbrook/declarative-overlay
branch
from
52bafff to
bf32f11
Compare
najikahalsema
previously approved these changes
Mar 15, 2021
Westbrook
force-pushed
the
westbrook/declarative-overlay
branch
2 times, most recently
from
0e87ad3 to
c05b063
Compare
cuberoot
previously approved these changes
Mar 17, 2021
Contributor
cuberoot
left a comment
cuberoot
left a comment
There was a problem hiding this comment.
Sweet. I am happy with the API change. I had requested the ability to declaratively open a popover some time ago. I hadn't thought of this approach, but I think it will add flexibility.
Westbrook
force-pushed
the
westbrook/declarative-overlay
branch
3 times, most recently
from
97143b5 to
40be896
Compare
Westbrook
force-pushed
the
westbrook/declarative-overlay
branch
from
40be896 to
02cacf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an
openattribute to the<overlay-trigger>element to declaratively outline which overlay content is open.Related Issue
fixes #424
Motivation and Context
Elements should be usable in a declarative fashion.
How Has This Been Tested?
New unit tests and VRTs.
Types of changes
Checklist: