Skip to content

Conversation

castastrophe
Copy link
Collaborator

@castastrophe castastrophe commented Jul 25, 2025

Description

  • Chromatic configuration is updated to support running Visual Regression Tests (VRT) against the spectrum-two branch
  • VRT runs are automated and triggered on all pull requests targeting spectrum-two
  • Results are properly reported and accessible to the team
  • Documentation is updated to reflect the new configuration

Why?

We need to enhance our Chromatic configuration to support automated VRT for pull requests targeting the spectrum-two branch. This will help us catch visual regressions early in the development process and ensure visual consistency across our components as we work on Spectrum 2 migrations.

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

  1. Create a test PR targeting the spectrum-two branch
  2. Push changes that would trigger a visual difference
  3. Verify that Chromatic automatically:
    • Runs the VRT process
    • Generates comparison results
    • Reports results in the expected location
  4. Verify that the baseline comparisons are made against spectrum-two
  5. Confirm that results are properly accessible to team members

To-do list

  • I have read the contribution guidelines.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@castastrophe castastrophe changed the base branch from main to spectrum-two July 25, 2025 22:33
@@ -79,7 +94,6 @@ jobs:
onlyChanged: true
traceChanged: true
untraced: ".github/* plugins/stylelint-*/* tools/* .changeset/*"
diagnostics: true
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This property is deprecated and no longer supported so I removed it.

@castastrophe castastrophe self-assigned this Jul 25, 2025
@castastrophe castastrophe added size-2 S ~6-18hrs; not hard or time consuming, one or two work days to complete. run_vrt For use on PRs looking to kick off VRT github_actions Pull requests that update GitHub Actions code S2 Spectrum 2 labels Jul 25, 2025
@castastrophe castastrophe marked this pull request as ready for review July 25, 2025 22:37
Copy link
Contributor

github-actions bot commented Jul 25, 2025

📚 Branch preview

PR #4070 has been deployed to Azure Blob Storage: https://spectrumcss.z13.web.core.windows.net/pr-4070/index.html.

Copy link
Contributor

github-actions bot commented Jul 25, 2025

File metrics

Summary

Total size: 1.44 MB*

🎉 No changes detected in any packages

* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@castastrophe castastrophe force-pushed the ci-chromatic-runs-spectrum-2 branch from 798b708 to c7b8e9e Compare July 26, 2025 00:31
Copy link

changeset-bot bot commented Jul 26, 2025

⚠️ No Changeset found

Latest commit: f11fa47

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@castastrophe castastrophe changed the title ci: chromatic runs for S2 ci: chromatic runs for S2 [CSS-1233] Jul 26, 2025
@castastrophe castastrophe force-pushed the ci-chromatic-runs-spectrum-2 branch 2 times, most recently from 57a0d4b to ef65717 Compare July 26, 2025 02:37
@castastrophe castastrophe force-pushed the ci-chromatic-runs-spectrum-2 branch from ef65717 to f11fa47 Compare July 28, 2025 16:55
@castastrophe castastrophe enabled auto-merge (squash) July 28, 2025 16:56
@castastrophe castastrophe added skip_vrt Add to a PR to skip running VRT (but still pass the action) and removed run_vrt For use on PRs looking to kick off VRT labels Jul 28, 2025
@castastrophe castastrophe disabled auto-merge July 28, 2025 17:11
@castastrophe castastrophe merged commit cc65f04 into spectrum-two Jul 28, 2025
10 of 32 checks passed
@castastrophe castastrophe deleted the ci-chromatic-runs-spectrum-2 branch July 28, 2025 17:11
@castastrophe castastrophe mentioned this pull request Aug 6, 2025
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code ready-for-review S2 Spectrum 2 size-2 S ~6-18hrs; not hard or time consuming, one or two work days to complete. skip_vrt Add to a PR to skip running VRT (but still pass the action)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants