Skip to content

fix(infield-button): updated border color for disabled state #3615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025
Merged

fix(infield-button): updated border color for disabled state #3615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/popular-trains-sniff.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@spectrum-css/infieldbutton": patch
---

### Infield button and stepper fast follows

- Updated infield button disabled border color to use `--spectrum-gray-300` for spectrum-two theme and `--spectrum-gray-200` for other themes.
2 changes: 2 additions & 0 deletions components/infieldbutton/dist/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@
"--spectrum-disabled-content-color",
"--spectrum-gray-100",
"--spectrum-gray-200",
"--spectrum-gray-300",
"--spectrum-neutral-content-color-default",
"--spectrum-neutral-content-color-down",
"--spectrum-neutral-content-color-hover",
Expand All @@ -146,6 +147,7 @@
"--system-infield-button-border-radius",
"--system-infield-button-border-radius-reset",
"--system-infield-button-border-width",
"--system-infield-button-disabled-border-color",
"--system-infield-button-stacked-bottom-border-radius-end-start",
"--system-infield-button-stacked-top-border-radius-start-start"
],
Expand Down
2 changes: 1 addition & 1 deletion components/infieldbutton/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
--mod-infield-button-background-color-hover: var(--mod-infield-button-background-color-hover-disabled, var(--spectrum-disabled-background-color));
--mod-infield-button-background-color-down: var(--mod-infield-button-background-color-down-disabled, var(--spectrum-disabled-background-color));

--mod-infield-button-border-color: var(--mod-infield-button-border-color-disabled, var(--spectrum-disabled-background-color));
--mod-infield-button-border-color: var(--mod-infield-button-border-color-disabled, var(--spectrum-infield-button-border-color));

--mod-infield-button-icon-color: var(--mod-infield-button-icon-color-disabled, var(--spectrum-disabled-content-color));
--mod-infield-button-icon-color-hover: var(--mod-infield-button-icon-color-hover-disabled, var(--spectrum-disabled-content-color));
Expand Down
4 changes: 4 additions & 0 deletions components/infieldbutton/themes/spectrum-two.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,9 @@
--spectrum-infield-button-background-color-hover: var(--spectrum-gray-200);
--spectrum-infield-button-background-color-down: var(--spectrum-gray-200);
--spectrum-infield-button-background-color-key-focus: var(--spectrum-gray-200);

&:disabled {
--spectrum-infield-button-border-color: var(--spectrum-gray-300);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably could be set to disabled-border-color if we wanted. I think that's also gray-300.

}
}
}
4 changes: 4 additions & 0 deletions components/infieldbutton/themes/spectrum.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,9 @@
--spectrum-infield-button-background-color-hover: var(--spectrum-gray-200);
--spectrum-infield-button-background-color-down: var(--spectrum-gray-300);
--spectrum-infield-button-background-color-key-focus: var(--spectrum-gray-200);

&:disabled {
--spectrum-infield-button-border-color: var(--spectrum-gray-200);
}
}
}
Loading