Skip to content

fix(slider): offset variant border radius bug fix #3611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 14, 2025
Merged

fix(slider): offset variant border radius bug fix #3611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2f3c0b
feat(slider): offset variant border radius bug fix
aramos-adobe Mar 10, 2025
54c3f11
feat(slider): fix range slider
aramos-adobe Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .changeset/rude-jokes-judge.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
"@spectrum-css/slider": minor
---

# Slider: offset variant track fix

The border radius styles were not being applied to the second instance of the `spectrum-Slider-track` when the offset variant is activated. The reason for this bug is because when the `offset` is selected, the template structure changes as `spectrum-Slider-fill` gets added to the slider.

Adding a sibling combinator `&~.spectrum-Slider-track` to `spectrum-Slider-track` when offset is activated resolved the issue.
1 change: 1 addition & 0 deletions components/slider/dist/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@
".spectrum-Slider-ticks ~ .spectrum-Slider-handleContainer .spectrum-Slider-handle",
".spectrum-Slider-track",
".spectrum-Slider-track ~ .spectrum-Slider-track",
".spectrum-Slider-track ~ .spectrum-Slider-track:before",
".spectrum-Slider-track:before",
".spectrum-Slider-track:first-of-type:before",
".spectrum-Slider-track:last-of-type:before",
Expand Down
8 changes: 8 additions & 0 deletions components/slider/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,6 +537,12 @@
&::before {
background: var(--highcontrast-slider-track-color-static, var(--mod-slider-track-color, var(--spectrum-slider-track-color)));
}

/* Styles below are applied to the sibling spectrum-Slider-track when filled-offset variant is activated */
& ~ .spectrum-Slider-track::before {
border-start-end-radius: var(--mod-slider-track-corner-radius, var(--spectrum-slider-track-corner-radius));
border-end-end-radius: var(--mod-slider-track-corner-radius, var(--spectrum-slider-track-corner-radius));
}
}

/* All variants other than filled-offset get a new track color for highcontrast mode */
Expand Down Expand Up @@ -621,6 +627,8 @@
.spectrum-Slider-track {
&:not(:first-of-type, :last-of-type)::before {
background: var(--highcontrast-slider-filled-track-fill-color, var(--mod-slider-track-fill-color, var(--spectrum-slider-track-fill-color)));
border-start-end-radius: 0;
border-end-end-radius: 0;
}
}
}
Expand Down
Loading