Skip to content

Conversation

pfulton
Copy link
Collaborator

@pfulton pfulton commented Jul 16, 2025

Description

🚨 BREAKING CHANGE 🚨
Removes the React icons from the project.

Additionally: this pulls in the 6.0.0 version of the A4U icons package (which also drops the react icons).

The changelog below for 5.1.0 and 5.0.0 lists out the changes in the package outside of dropping the react icons. There are many deletions in this PR that could not be separated out into an individual commit, so a heads-up that the files changed number may be a bit intimidating initially.

Copy/pasted changelog from the 5.1.0 package below:

[5.1.0]

Date: Wed Jul 16 2025 19:37:27 GMT+0200 (Central European Summer Time)

Comment: adding 1 new icon

Added

  • S2_Icon_HeartFilled_20_N.svg

Changed

  • S2_Icon_SpeedFast_20_N.svg

[5.0.0]

Date: Thu Jun 12 2025 13:43:03 GMT+0200 (Central European Summer Time)

Comment: replaced all 22x20px cloud state icons with its new 20px variants.
Removed the deprecated multi colored "S2_Icon_CloudStateErrorRed_22x20_N.svg"

Added

  • S2_Icon_CloudStateDisconnected_20_N.svg
  • S2_Icon_CloudStateError_20_N.svg
  • S2_Icon_CloudStateInProgress_20_N.svg
  • S2_Icon_CloudStateOnline_20_N.svg
  • S2_Icon_CloudStatePaused_20_N.svg
  • S2_Icon_CloudStatePending_20_N.svg
  • S2_Icon_CloudStateSlowConnection_20_N.svg

Changed

  • S2_Icon_CloseCaptions_20_N.svg
  • S2_Icon_CommentHide_20_N.svg
  • S2_Icon_Community_20_N.svg
  • S2_Icon_Erase_20_N.svg
  • S2_Icon_FlipHorizontal_20_N.svg
  • S2_Icon_FlipVertical_20_N.svg
  • S2_Icon_ImageAdd_20_N.svg
  • S2_Icon_Images_20_N.svg
  • S2_Icon_Pattern_20_N.svg
  • S2_Icon_Play_20_N.svg
  • S2_Icon_StrokeDotted_20_N.svg
  • S2_Icon_Template_20_N.svg
  • S2_Icon_UserAvatarCursor_20_N.svg
  • S2_Icon_UserSettings_20_N.svg

Deleted

  • S2_Icon_CloudStateDefault_22x20_N.svg
  • S2_Icon_CloudStateDisconnected_22x20_N.svg
  • S2_Icon_CloudStateErrorRed_22x20_N.svg
  • S2_Icon_CloudStateError_22x20_N.svg
  • S2_Icon_CloudStateInProgress_22x20_N.svg
  • S2_Icon_CloudStatePaused_22x20_N.svg
  • S2_Icon_CloudStatePending_22x20_N.svg
  • S2_Icon_CloudStateSlowConnection_22x20_N.svg
  • S2_Icon_MediaOffline_N.svg
  • S2_Icon_CloudStateOnline_22x20_N.svg

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

changeset-bot bot commented Jul 16, 2025

🦋 Changeset detected

Latest commit: 33f6739

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@adobe/spectrum-css-workflow-icons Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pfulton pfulton marked this pull request as draft July 17, 2025 14:02
@pfulton pfulton added the do not merge don't merge this label Jul 17, 2025
pfulton added 2 commits July 21, 2025 11:12
BREAKING CHANGE: removes react icons from the project

* Removes react icons from the project
* Takes in the latest release from A4U, (which also drops the react icons)
* Refactors the project scripts to remove references to react processing
Copy link
Contributor

github-actions bot commented Aug 19, 2025

@github-actions github-actions bot temporarily deployed to pull request August 19, 2025 17:48 Inactive
Copy link

netlify bot commented Aug 19, 2025

Deploy Preview for spectrum-workflow-icons ready!

Name Link
🔨 Latest commit 33f6739
🔍 Latest deploy log https://app.netlify.com/projects/spectrum-workflow-icons/deploys/68a4be1f3df2350008dd3eda
😎 Deploy Preview https://deploy-preview-50--spectrum-workflow-icons.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pfulton pfulton changed the title feat: take in 5.1.0 update feat!: take in 6.0.0 a4u package, drop react icons Aug 19, 2025
@pfulton pfulton marked this pull request as ready for review August 19, 2025 18:11
@pfulton pfulton removed the do not merge don't merge this label Aug 19, 2025
@pfulton pfulton merged commit 7eff715 into main Aug 25, 2025
11 checks passed
@pfulton pfulton deleted the pfulton/a4u-510-release branch August 25, 2025 17:07
@github-actions github-actions bot mentioned this pull request Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants