fix: Fix onAction with keyboard in ComboBox and add docs #8910
+198
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devongovett
commented
Sep 23, 2025
| return ( | ||
| <ComboBox | ||
| label="Favorite Animal" | ||
| allowsEmptyCollection |
There was a problem hiding this comment.
Unfortunately this is currently required or the ComboBox will close due to the collection double render. inputValue updates and we filter again against the old collection, which will now be empty due to the old item being filtered out, so the combobox closes. then on the next render the collection updates but it's too late. Not sure of a good way to fix that automatically other than adding this prop, but it's a bit non-obvious.
|
Build successful! 🎉 |
snowystinger
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8884, closes #8831
The
onActionprop is accepted byListBoxItem/ComboBoxItemin S2 but doesn't actually work with the keyboard. This PR fixes that so it works like links, where actionable items are not selectable.Also adds docs for both RAC and S2 for the commonly requested use case of adding a "Create" action to a ComboBox.