feat: table "inline" editing #8754
Open
+760
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! 🎉 |
|
Build successful! 🎉 |
…nvalid state, click off
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
snowystinger
commented
Aug 27, 2025
| let boundaryStartEdge = boundaryDimensions.scroll[AXIS[axis]] + padding; | ||
| let boundaryEndEdge = boundarySize + boundaryDimensions.scroll[AXIS[axis]] - padding; | ||
| let startEdgeOffset = offset - containerScroll + containerOffsetWithBoundary[axis] - boundaryDimensions[AXIS[axis]]; | ||
| let startEdgeOffset = offset - containerScroll + containerOffsetWithBoundary[axis]; |
There was a problem hiding this comment.
ignore this change for a bit, might be a bug in our positioning code
…plementation to make generic, fix density, individual cell saving state, use touch detection for showing all the time
snowystinger
commented
Aug 28, 2025
| **/ | ||
| onAction?: () => void | ||
| onAction?: () => void, | ||
| focusMode?: 'cell' | 'child' |
There was a problem hiding this comment.
change we'd need to make if we want to support edit mode on some cells vs others
|
Build successful! 🎉 |
snowystinger
commented
Aug 28, 2025
| context={TextContext} | ||
| value={{ | ||
| slots: { | ||
| [DEFAULT_SLOT]: {styles: label({size})}, |
There was a problem hiding this comment.
this is just a missing feature we should really have in S2
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
# Conflicts: # packages/@react-spectrum/s2/src/ActionButton.tsx # packages/@react-spectrum/s2/stories/TableView.stories.tsx # packages/react-aria-components/src/Button.tsx # packages/react-aria-components/test/Button.test.js
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
## API Changes
@react-spectrum/s2/@react-spectrum/s2:EditableCell+EditableCell {
+ align?: 'start' | 'center' | 'end' = 'start'
+ children: ReactNode
+ className?: ClassNameOrFunction<CellRenderProps>
+ colSpan?: number
+ id?: Key
+ isSaving?: boolean
+ onCancel: () => void
+ onSubmit: () => void
+ renderEditing: () => ReactNode
+ showDivider?: boolean
+ style?: StyleOrFunction<CellRenderProps>
+ textValue?: string
+} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RSP Component Milestones (view)
Implements our Editable Cell component for Table's. Note, this is called inline editing by Spectrum at the moment, but it does not correlate to aria inline editing.
This essentially works around the issue of textfields in cells or anything else in cells.
Will be adding more tests
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: