feat: (WIP) Support virtual focus for grid components #8728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 15, 2025
Base automatically changed from
autocomplete_context_refactor
to
baseCollection_filter
August 18, 2025 18:09
previously ArrowLeft wasnt moving off the button when using virtual focus since the row isnt a focusable element from the focusable treewalker point of view. Can now be verfied via the aria activedescendat attribute
still a bunch of bugs, see notes
LFDanLu
force-pushed
the
support_grid_autocomplete
branch
from
0b6c076 to
423f1b6
Compare
was resulting in focus visible sticking around on the row/tag when tabbing to child
…obe/react-spectrum into support_grid_autocomplete
this fixes the logic so we always let the collection determine what to focus instead of focusing the last focused node when focusing the input. this gets rid of the dupe focus issue in taggroup while preserving the proper input focusing clearing problem for shift tabbing into a autocomplete menu. Also fixes some id assignment and other bugs like clicking on the input instead of shift tabbing then tabbing forward
|
closing for now, not many real world use cases I could find for grid collection virtual focus so will focus on just detecting if wrapped component doesn't support virtual focus |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project:
RSP