fix: check for element visibility should take react aria attribute into consideration #8642
+52
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowystinger
commented
Jul 26, 2025
| @@ -63,9 +63,9 @@ function isAttributeVisible(element: Element, childElement?: Element) { | |||
| */ | |||
| export function isElementVisible(element: Element, childElement?: Element): boolean { | |||
| if (supportsCheckVisibility) { | |||
| return element.checkVisibility(); | |||
| return element.checkVisibility() && !element.closest('[data-react-aria-prevent-focus]'); | |||
There was a problem hiding this comment.
not convinced this is where the check should be given the name of the function vs the name of the attribute...
There was a problem hiding this comment.
yeah this is a bit confusing cuz of the naming, but if I understand this correctly, this is to make it so isTabbable/isFocusable don't resolve as true for elements with the above data attribute correct? Any reason we don't move this check into those functions?
There was a problem hiding this comment.
It'd be annoying to do it there because you have to check all the parents as well. I think it's ok here for now
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
devongovett
approved these changes
Aug 5, 2025
LFDanLu
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8636
Can't test in jsdom because it behaved correctly both ways, it seems to be wrong about element visibility compared to browsers.
Test in the story.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: