WIP: fix(DnD): avoid unnecessary re-renders when drag modality changes. #8413
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2504
Related #2403
Adds
useDynamicDescription
, an alternative touseDescription
that reuses the description node and id to avoid excessive re-renders when the description text changes. Fixes the issue where changing drag modality causes all the drop targets on a page to re-render.TODO: might need a mechanism to ensure shared elements aren't changed when another consumer still relies on the old text (not an issue for modality change, but might come up somewhere else).
TODO: Investigate why some tests are failing only in React 18
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: