-
Notifications
You must be signed in to change notification settings - Fork 38
Content Card Container Capacity #541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jkartoshka
merged 23 commits into
adobe:content-card-containers
from
jkartoshka:container-capacity
Oct 23, 2025
Merged
Content Card Container Capacity #541
jkartoshka
merged 23 commits into
adobe:content-card-containers
from
jkartoshka:container-capacity
Oct 23, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…content-card-containers
…content-card-containers
…content-card-containers
…plicate color scheme variable
…content-card-containers
…content-card-containers
packages/messaging/src/ui/components/ContentCardContainer/ContentCardContainer.tsx
Outdated
Show resolved
Hide resolved
…container-capacity
dsoffiantini
approved these changes
Oct 23, 2025
| EmptyComponent?: ReactElement | null; | ||
| surface: string; | ||
| settings: ContainerSettings | null; | ||
| isLoading?: boolean; |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because we moved the hook out of this component, we should also these state pieces and their components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding Content Card Container Capacity where we only render the number of cards up to the limit of the container settings. When a user dismisses one, the next one will pop in if there is any other ones
Related Issue
https://jira.corp.adobe.com/browse/MOB-24154
Motivation and Context
Content Card Container Functionality in React Native
How Has This Been Tested?
Changed capacity to 2. When dismissing one the next one pops up
Screenshots (if appropriate):
Types of changes
Checklist: