Add Edge Identity network extension package #33

cacheung · 2021-09-01T02:38:12Z

Add Edge Identity network extension package

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

I have signed the Adobe Open Source CLA.
My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

Init code for react native Edge

More updates

Update iOS implementation

Some more Android side change

React Native Edge extension

React Native AEPAssurance v3.0.0 package

Fix the build - Set right the unit tests

clean up files

Update iOS code and clean up files

Add unit test and update Readme

Cleanup few files

Update for review comments

Update package json for Edge package.

update readme file

This reverts commit 9f82a4a.

Add Edge Identity network extension package

cacheung · 2021-09-01T02:40:34Z

apps/AEPSampleApp/extensions/Core.js

 import {Button, Platform, StyleSheet, Text, View, ScrollView, NativeModules} from 'react-native';
-import {AEPCore, AEPLifecycle, AEPSignal, AEPMobileLogLevel, AEPMobilePrivacyStatus, AEPMobileVisitorAuthenticationState, AEPVisitorID, AEPExtensionEvent} from '@adobe/react-native-aepcore';
+import {AEPIdentity as AEPIdentity, AEPCore, AEPLifecycle, AEPSignal, AEPMobileLogLevel, AEPMobilePrivacyStatus, AEPMobileVisitorAuthenticationState, AEPVisitorID, AEPExtensionEvent } from '@adobe/react-native-aepcore';
+import {AEPIdentity as AEPEdgeIdentity } from '@adobe/react-native-aepedgeidentity';


Should we add sample for core Identity and Edge Identity here?

We can have a separate view for Edge Identity.
It might be a good idea to make this sample app similar with the Swift Sample app in how the extensions are demoed and split in separate views.

I have a separate view for Edge Identity. But wondering if need to give an example how user can import when have both identities in one view.

iOS main view

Core API View

Edge Identity View

I think we can keep an example with importing both, but the Edge Identity extension does not need to be included in Core.js. Maybe we can create a separate file for it?

I removed import Edge Identity from Core view.
Add an EdgeIdentityAndIdentity.js file for both Identities case.

Update with more review comments

cacheung · 2021-09-02T21:54:17Z

@cacheung Can we remove RCTAEPEdgeIdentityArrayUtil.java and RCTAEPEdgeIdentityMapUtil.java in this PR? I don't see any usage.

@yangyansong-adbe removed.

AEPAssurance 3.x package to Staging

Update tests and fix few bugs

Update Java Data Bridge for EdgeEventHandle payload and Readme

update for review comments

update identity register info

Update registering info for Readme

Update Readme initializing instruction

Update Readme and MainApplication.java

cacheung · 2021-09-04T00:34:52Z

packages/edgeidentity/README.md

+AEPIdentity.extensionVersion().then(version => console.log("AdobeExperienceSDK: AEPEdgeIdentity version: " + version));
+```
+
+#### In the case of AEPIdentities and Identity for Edge Network in the same app


Should we put two identities case here?

I don't think we need to include this in the readme of the Edge Identity extension, we can consider adding it later in the main readme if needed. We can also remove the example with two Identity above

cacheung · 2021-09-04T00:35:54Z

packages/edgeidentity/README.md

+    MobileCore.setLogLevel(LoggingMode.DEBUG);
+    MobileCore.setWrapperType(WrapperType.REACT_NATIVE);
+
+    try {


Should we have two identity registering info here?

emdobrin · 2021-09-05T02:41:30Z

apps/AEPSampleApp/App.js

+      <Button
+        onPress={() => navigation.navigate('EdgeIdentityAndIdentity')}
+        title="EdgeIdentityAndIdentity"
+      />


Let's remove this, we can keep only the Identity and EdgeIdentity views.

emdobrin · 2021-09-05T02:44:13Z

apps/AEPSampleApp/extensions/EdgeIdentityAndIdentity.js

+import {AEPIdentity as AEPIdentity, AEPCore} from '@adobe/react-native-aepcore';
+import {AEPIdentity as AEPEdgeIdentity } from '@adobe/react-native-aepedgeidentity';
+
+export default EdgeIdentityAndIdentity = ({ navigation }) => {


No need to keep this example, let's remove.

emdobrin · 2021-09-05T02:49:15Z

packages/edgeidentity/ios/RCTAEPEdgeIdentity.xcodeproj/project.pbxproj

+			isa = PBXGroup;
+			children = (
+				B3E7B5881CC2AC0600A0062D /* RCTAEPUserProfile.h */,
+				B3E7B5891CC2AC0600A0062D /* RCTAEPUserProfile.m */,


there seem to be some UserProfile related files here 😅 let's remove/update these to Edge Identity related ones.

emdobrin · 2021-09-05T02:49:47Z

packages/edgeidentity/ios/RCTAEPEdgeIdentity.xcodeproj/project.pbxproj

+				GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
+				GCC_WARN_UNUSED_FUNCTION = YES;
+				GCC_WARN_UNUSED_VARIABLE = YES;
+				IPHONEOS_DEPLOYMENT_TARGET = 8.0;


Should be IPHONEOS_DEPLOYMENT_TARGET = 8.0; - same for all occurrences.

@emdobrin Thanks for the review, I will update them. For this one, what is the difference IPHONEOS_DEPLOYMENT_TARGET = 8.0;?

emdobrin · 2021-09-05T02:50:38Z

packages/edgeidentity/ios/RCTAEPEdgeIdentity.xcodeproj/project.pbxproj

+		134814211AA4EA7D00B7C361 /* Products */ = {
+			isa = PBXGroup;
+			children = (
+				134814201AA4EA6300B7C361 /* libRCTAEPUserProfile.a */,


incorrect product section, states user profile

emdobrin · 2021-09-05T05:40:43Z

.../main/java/com/adobe/marketing/mobile/reactnative/edgeidentity/RCTAEPEdgeIdentityModule.java

+ */
+package com.adobe.marketing.mobile.reactnative.edgeidentity;
+
+import com.adobe.marketing.mobile.AdobeCallback;


not used, can be removed

emdobrin · 2021-09-05T05:47:39Z

packages/edgeidentity/README.md

+AEPIdentity.extensionVersion().then(version => console.log("AdobeExperienceSDK: AEPEdgeIdentity version: " + version));
+```
+
+#### In the case of AEPIdentities and Identity for Edge Network in the same app


I don't think we need to include this in the readme of the Edge Identity extension, we can consider adding it later in the main readme if needed. We can also remove the example with two Identity above

… project file Remove EdgeIdentityAndIdentity view in sample app and fix typo in iOS project file

update project file target to IPHONEOS_DEPLOYMENT_TARGET = 10.0;

Update with review comments

Add React Native AEP Edge

Update edge extension version number

Update edge Identity alpha version number

Update podfile

Sync with the latest staging branch

Edge (1.0.0-alpha.1) -> staging

…dentityEdge

Update readme extensions download path

yangyansong-adbe and others added 29 commits August 4, 2021 16:08

Initialize project

a7442ee

Init code for react native Edge

d6c256e

Init code for react native Edge

More updates

5ef4134

More updates

Update iOS implementation

4ef223f

Update iOS implementation

Some more Android side change

3750581

Some more Android side change

Merge pull request adobe#11 from cacheung/Edge

04dc08c

React Native Edge extension

Adding Assurance package: Podspec + js api’s

d22cea1

Adding Assurance package: iOS bridge layer

db4a0da

Adding Assurance package: Android bridge layer

28903a5

Adding Assurance package: ReadMe + tests

31a306a

Adding Assurance package: add git ignore files

0942335

Update the sample app with Assurance

1111fc8

Merge staging and resolve conflicts

71f37c9

Add startSession test + some renamings

1f3eb72

Merge pull request adobe#25 from PravinPK/assurance

be2f630

React Native AEPAssurance v3.0.0 package

Merge branch 'staging' of github.com:adobe/aepsdk-react-native into edge

267ef6d

Fix build probs

0c10327

Merge pull request adobe#26 from PravinPK/assurance

be16430

Fix the build - Set right the unit tests

clean up files

bdc2177

clean up files

Merge branch 'staging' of github.com:adobe/aepsdk-react-native into edge

a893613

Update iOS code and clean up files

69bcd9d

Update iOS code and clean up files

Add unit test and update Readme

9cd2464

Add unit test and update Readme

Cleanup few files

cca0833

Cleanup few files

Update for review comments

c4ccc64

Update for review comments

Update package json for Edge package.

6cb6146

Update package json for Edge package.

Add publish Config to Assurance

0fcc6aa

update readme file

9f82a4a

update readme file

Revert "update readme file"

664a802

This reverts commit 9f82a4a.

Add Edge Identity network extension package

e3d61dd

Add Edge Identity network extension package

cacheung commented Sep 1, 2021

View reviewed changes

Update with more review comments

7378117

Update with more review comments

PravinPK and others added 11 commits September 2, 2021 15:11

default assurance session URL

f5e8a35

Merge pull request adobe#34 from adobe/assurance

1b1c5db

AEPAssurance 3.x package to Staging

Update tests and fix few bugs

112597c

Update tests and fix few bugs

Add the SDK initialization docs to READMEs (adobe#35)

0f935d4

Update Java Data Bridge for payload EdgeEventHandle and Readme

37bc88c

Update Java Data Bridge for EdgeEventHandle payload and Readme

update for review comments

fffa2e5

update for review comments

update identity register info

02ec9da

update identity register info

Update registering info for Readme

b185a42

Update registering info for Readme

Update Readme initializing instruction

1058916

Update Readme initializing instruction

remove AEPMobileIdentity.class from Readme

1441894

Update Readme and MainApplication.java

6c1ad58

Update Readme and MainApplication.java

cacheung commented Sep 4, 2021

View reviewed changes

emdobrin reviewed Sep 5, 2021

View reviewed changes

cacheung added 3 commits September 6, 2021 20:12

Remove EdgeIdentityAndIdentity view in sample app and fix typo in iOS…

343d6d0

… project file Remove EdgeIdentityAndIdentity view in sample app and fix typo in iOS project file

update project file target to IPHONEOS_DEPLOYMENT_TARGET = 10.0;

ff0c47a

update project file target to IPHONEOS_DEPLOYMENT_TARGET = 10.0;

Update with review comments

36ce696

Update with review comments

yangyansong-adbe approved these changes Sep 7, 2021

View reviewed changes

cacheung added 9 commits September 7, 2021 09:49

Merge pull request adobe#29 from cacheung/edge

ea5405a

Add React Native AEP Edge

Update edge extension version number

bb0b87a

Update edge extension version number

Update edge Identity version number

ae9c3d2

Update edge Identity alpha version number

Merge branch 'staging' of github.com:adobe/aepsdk-react-native into edge

b1aeb87

Update podfile

a63a421

Update podfile

Merge pull request adobe#36 from cacheung/edge

c2ed018

Sync with the latest staging branch

Merge pull request adobe#37 from adobe/edge

bb78c65

Edge (1.0.0-alpha.1) -> staging

Merge branch 'staging' of github.com:adobe/aepsdk-react-native into i…

a6ad606

…dentityEdge

Update readme extensions download path

7c9d509

Update readme extensions download path

cacheung merged commit d2488ca into adobe:edgeIdentity Sep 7, 2021

Add Edge Identity network extension package #33

Add Edge Identity network extension package #33

Uh oh!

Conversation

cacheung commented Sep 1, 2021

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cacheung Sep 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cacheung Sep 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

emdobrin Sep 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cacheung commented Sep 2, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cacheung Sep 1, 2021 •

edited

Loading

cacheung Sep 1, 2021 •

edited

Loading

emdobrin Sep 1, 2021 •

edited

Loading