Skip to content

Conversation

@dsoffiantini
Copy link
Contributor

Description

Updates to messaging to include latest IAM changes

How Has This Been Tested?

Unit tests have been added

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@cacheung
Copy link
Contributor

Getting console warning when calling Refreshinappmessages() and Setmessagingdelegate() in the Messaging view of the sample app. new NativeEventEmitter() was called with a non-null arguement without the required 'removeLIsterners' method.
Will this affect users who use messaging and optimize?

Copy link
Contributor

@cacheung cacheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to regenerated a Podfile.lock for sample app. The current one giving error when run pod install
[!] CocoaPods could not find compatible versions for pod "AEPEdge":
In snapshot (Podfile.lock):
AEPEdge (= 1.5.0, >= 1.1.0, >= 1.2.0, >= 1.4.0, ~> 1.0)

In Podfile:
AEPMessaging (from https://github.com/adobe/aepsdk-messaging-ios.git, branch staging) was resolved to 1.1.0-beta2, which depends on
AEPEdge (>= 1.1.0)

RCTAEPEdge (from `../../../packages/edge`) was resolved to 1.0.0, which depends on
  AEPEdge (~> 1.0)

You have either:

  • out-of-date source repos which you can update with pod repo update or with pod install --repo-update.
  • changed the constraints of dependency AEPEdge inside your development pod RCTAEPEdge.
    You should run pod update AEPEdge to apply changes you've made.

@cacheung
Copy link
Contributor

Need to change the Sample App package.json to 1.0.0-beta.3 for messaging.

@dsoffiantini
Copy link
Contributor Author

This is just a react native warning that doesnt affect functionality, but I can add some code to remove the warning

@dsoffiantini dsoffiantini merged commit d19596c into staging Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants