Skip to content

Conversation

@dsoffiantini
Copy link
Contributor

Description

This is a small fix that removes a console warning on android apps due to the package not having add and remove listener functions react native looks for in android. Functionality is not affected.

Screenshots (if appropriate):

Previous warning:
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dsoffiantini dsoffiantini force-pushed the android-event-emitter-warning branch 3 times, most recently from 0c6bd36 to ba16b17 Compare July 20, 2022 16:28
@dsoffiantini dsoffiantini force-pushed the android-event-emitter-warning branch from ba16b17 to 371e566 Compare July 20, 2022 16:31
@dsoffiantini dsoffiantini merged commit 6d328e4 into optimize Jul 20, 2022
@dsoffiantini dsoffiantini deleted the android-event-emitter-warning branch July 20, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants