AJO Optimize RN Package #177

dsoffiantini · 2022-05-10T16:16:23Z

Description

Contains the AJO Optimize RN package and sample app, as well as Messaging updates that enable In-App-Messaging functionality, and changes to the underlying packages that enable them now that optimize has been released officially.

Motivation and Context

Enables users to install the optimize sdk and use it on their react native apps, and sets them up to test IAM features if they want to

How Has This Been Tested?

Unit tests have been added to all new functionality

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

I have signed the Adobe Open Source CLA.
My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

…optimize

…tracking.

…nd js.

…teractionXDM

Updated Readme with following: 1. Installation instructions 2. APIs in AEPOptimize module

Added documentation on following public classes: - DecisionScope - Offer - Proposition

…optimize Merge the upstream

…d() calls

… into optimize

cacheung

Some feedback for Optimize.

packages/optimize/README.md

cacheung · 2022-06-22T21:56:39Z

packages/optimize/README.md

 The Adobe Experience Platform Optimize extension has the following peer dependency, which must be installed prior to installing the optimize extension:
 - [Core](../core/README.md)
 - [Edge](../edge/README.md)
+- [Edge Identity](../edgeidentity/README.md)


Below for line 44,
Add EdgeIdentity to import and registration since it is the dependency.
Add for both Android and iOS registration sample.

@import AEPCore;
@import AEPLifecycle;
@import AEPEdge;
@import AEPOptimize;

Can we also register for iOS
[AEPMobileCore registerExtensions: @[AEPMobileEdge.class, AEPMobileEdgeIdentity.class, AEPMobileOptimize.class] completion:^

Register for Android
Identity.registerExtension();

@dsoffiantini Can we add register AEPMobileEdgeIdentity.class in the sample code?

Also add to Android, Identity.registerExtension();
Since EdgeIdentity is a dependency.

packages/optimize/README.md

cacheung

https://github.com/adobe/aepsdk-react-native/blob/optimize/packages/messaging/package.json#L29

"@adobe/react-native-aepcore": "^1.0.0",
"@adobe/react-native-aepedge": "^1.0.0",
"@adobe/react-native-aepedgeidentity": "^1.0.0",

cacheung · 2022-06-24T00:46:57Z

packages/messaging/README.md

 npm install {path to node package file}
 ```

 **Podfile setup for `@adobe/react-native-aepmessaging` v1.0.0-beta.2 with in-app messaging support**  


Podfile setup for @adobe/react-native-aepmessaging iOS SDK v1.0.0-beta.2 with in-app messaging support

This sounds clearer for iOS version?

cacheung · 2022-06-24T00:47:25Z

packages/messaging/README.md


-**Gradle setup for `@adobe/react-native-aepmessaging` v1.0.0-beta.2 with in-app messaging support**
-AEPMessaging Android package v1.1.0 with in-app messaging support is not published to maven yet. In project level build.gradle file of Android project in your RN application add following changes in `allprojects -> repositories`. 
+**Gradle setup for `@adobe/react-native-aepmessaging` v1.2.0-beta.1 with in-app messaging support**


Gradle setup for @adobe/react-native-aepmessaging Android SDK v1.2.0-beta.1 with in-app messaging support

It is not clear to me what user need to do for messaging extension by following the Readme.
Let revisit.

packages/messaging/README.md

cacheung · 2022-06-24T00:49:38Z

packages/messaging/README.md

+
 ...
 import android.app.Application;
 ...


cacheung · 2022-06-24T01:00:05Z

packages/optimize/README.md

 The Adobe Experience Platform Optimize extension has the following peer dependency, which must be installed prior to installing the optimize extension:
 - [Core](../core/README.md)
 - [Edge](../edge/README.md)
+- [Edge Identity](../edgeidentity/README.md)


Can we also register for iOS
[AEPMobileCore registerExtensions: @[AEPMobileEdge.class, AEPMobileEdgeIdentity.class, AEPMobileOptimize.class] completion:^

Register for Android
Identity.registerExtension();

cacheung · 2022-06-24T01:02:29Z

packages/messaging/README.md

@@ -1,7 +1,7 @@

 # React Native Adobe Experience Platform Messaging Extension


nit: change all
javascript code block

to
typescript code block

cacheung · 2022-06-24T01:04:45Z

packages/optimize/android/build.gradle

+    repositories {
+        google()
+        mavenCentral()
+        maven { url "https://oss.sonatype.org/content/repositories/snapshots/" }


We don't need this for Optimize right?

cacheung · 2022-06-24T01:06:03Z

packages/optimize/android/build.gradle

+repositories {
+    google()
+    mavenCentral()
+    maven { url "https://oss.sonatype.org/content/repositories/snapshots/" }   


Same we don't this for Optimize.

yangyansong-adbe · 2022-06-24T20:24:55Z

README.md

 |  [@adobe/react-native-aepmessaging](./packages/messaging)  |  [![npm version](https://badge.fury.io/js/%40adobe%2Freact-native-aepmessaging.svg)](https://www.npmjs.com/package/@adobe/react-native-aepmessaging) [![npm downloads](https://img.shields.io/npm/dm/@adobe/react-native-aepmessaging)](https://www.npmjs.com/package/@adobe/react-native-aepmessaging)  | [Messaging](https://aep-sdks.gitbook.io/docs/beta/iam)
-|  [@adobe/react-native-aepassurance](./packages/assurance)    |  [![npm version](https://badge.fury.io/js/%40adobe%2Freact-native-aepassurance.svg)](https://www.npmjs.com/package/@adobe/react-native-aepassurance) [![npm downloads](https://img.shields.io/npm/dm/@adobe/react-native-aepassurance)](https://www.npmjs.com/package/@adobe/react-native-aepassurance)  | [Assurance](https://aep-sdks.gitbook.io/docs/foundation-extensions/adobe-experience-platform-assurance)
+|  [@adobe/react-native-aepassurance](./packages/assurance)    |  [![npm version](https://badge.fury.io/js/%40adobe%2Freact-native-aepassurance.svg)](https://www.npmjs.com/package/@adobe/react-native-aepassurance) [![npm downloads](https://img.shields.io/npm/dm/@adobe/react-native-aepassurance)](https://www.npmjs.com/package/@adobe/react-native-aepassurance) | [Assurance](https://aep-sdks.gitbook.io/docs/foundation-extensions/adobe-experience-platform-assurance) 
+| [@adobe/react-native-aepoptimize](./packages/optimize) | [![npm downloads](https://img.shields.io/npm/dm/@adobe/react-native-aepassurance)](https://www.npmjs.com/package/@adobe/react-native-aepoptimize) ![npm downloads](https://img.shields.io/npm/dm/@adobe/react-native-aepoptimize)  | [Optimize](https://aep-sdks.gitbook.io/docs/using-mobile-extensions/adobe-journey-optimizer-decisioning)


(https://img.shields.io/npm/dm/@adobe/react-native-aepassurance)
The above URL should show the downloads for Assurance, can we correct it with theaepoptimize URL?

yangyansong-adbe · 2022-06-24T20:28:20Z

package.json

    "babel-preset-react-native": "5.0.2",
    "jest": "^27.5.1",
    "lerna": "^4.0.0",
+    "metro-react-native-babel-preset": "^0.70.1",


Can we move this metro dependency to the sample app level as it should only be used by the sample app?

After changing this one, unit tests wont be able to run so it has to stay at this level

yangyansong-adbe · 2022-06-24T20:40:57Z

https://github.com/adobe/aepsdk-react-native/pull/177/files#diff-e7e2f2b83ea901f4ba22c4027cbee641a70899f27e9d03e5cf95b3cb3bf12acdR45
@dsoffiantini I saw that we have included some messaging changes in this PR. Ideally, we should only update the Optimize extension in optimize branch and then merge the extension branch to staging. If we have to include changes for both extensions in the same PR, can you add some descriptions to this PR?
cc @cacheung

cacheung · 2022-06-24T21:48:29Z

https://github.com/adobe/aepsdk-react-native/pull/177/files#diff-e7e2f2b83ea901f4ba22c4027cbee641a70899f27e9d03e5cf95b3cb3bf12acdR45
@dsoffiantini I saw that we have included some messaging changes in this PR. Ideally, we should only update the Optimize extension in optimize branch and then merge the extension branch to staging. If we have to include changes for both extensions in the same PR, can you add some descriptions to this PR?
cc @cacheung

Good point for the description. We were providing a local build to the user which had to include Optimize and Messaging. So we have both Optimize and Messaging in this branch. We continued making all the changes in this PR after. @dsoffiantini Once this PR merges in to the Staging, we should also pull the staging down to Messaging branch to make it to the latest.

…into optimize

cacheung · 2022-07-16T01:35:10Z

apps/AEPSampleApp/package.json

    "@adobe/react-native-aepedgeconsent": "^1.0.0",
    "@adobe/react-native-aepedgeidentity": "^1.1.0",
-    "@adobe/react-native-aepmessaging": "^1.0.0-beta.2",
+    "@adobe/react-native-aepmessaging": "^1.0.0-beta.3",


Should we change it back to beta.2 since not releasing Messaging?

cacheung · 2022-07-16T01:36:07Z

packages/messaging/README.md


-**Installation instructions for `@adobe/react-native-aepmessaging` v1.0.0-beta.2 with in-app messaging support**  
-Download the node package `adobe-react-native-aepmessaging-1.0.0-beta.2.tgz` from [github release](https://github.com/adobe/aepsdk-react-native/releases/tag/%40adobe%2Freact-native-aepmessaging%401.0.0-beta.2) and save it in a folder.  
+**Installation instructions for `@adobe/react-native-aepmessaging` v1.0.0-beta.3 with in-app messaging support**   


Change back to beta.2

cacheung · 2022-07-16T01:39:25Z

packages/messaging/README.md

 ```bash
 cd MyReactApp
-npm install {path to node package file}
+npm install @adobe/react-native-aepmessaging


User should install from the instruction in prerelease md?
Do we want to user to use npm install @adobe/react-native-aepmessaging?

cacheung · 2022-07-16T01:39:46Z

packages/messaging/README.md


-**Podfile setup for `@adobe/react-native-aepmessaging` v1.0.0-beta.2 with in-app messaging support**  
-The In app Message APIs depends on the AEP Messaging, v1.1.0. This version is not yet published to the Cocoapods but is available in the public [github repository](https://github.com/adobe/aepsdk-messaging-ios/tree/staging). Add the following pod dependency in your applications Podfile under the application target. 
+**Podfile setup for `@adobe/react-native-aepmessaging` v1.0.0-beta.3 with in-app messaging support**  


cacheung · 2022-07-16T01:44:47Z

packages/messaging/package.json

 {
  "name": "@adobe/react-native-aepmessaging",
-  "version": "1.0.0-beta.2",
+  "version": "1.0.0-beta.3",


Change back to 1.0.0-beta.2

…into optimize

cacheung

Looks good!!

shtomar-adb and others added 30 commits October 21, 2021 18:09

Initial commit. Added Optimize RN package and Android sample app.

931ee72

Update README.md

dd46322

Added classed offer and Proposition

10646c1

Merge branch 'optimize' of github.com:adobe/aepsdk-react-native into …

8a8cde6

…optimize

Added model class Offer and Preposition in js and hadle Offer tapped …

8517f67

…tracking.

Added podspec in Optimize wrapper.

e28cace

Added RN wrapper ios bridge code

80cce92

Updated js files with values type.

a41080a

Modified the model classes Offer, Proposition, DecisionScope

e60abad

Code optimization in model classes and data movement between native a…

c48da13

…nd js.

Updated Android aar and made necessary changes in js and Android native.

edb49ba

Added following 2 news js API: generateReferenceXDM and generateTapIn…

c0a4ec9

…teractionXDM

Made changes in ios code to integrate with changes in JS API.

bd8f578

code review feedback

490b539

Code review feedback

30d1816

Code review feedback.

47fc39c

Removed flow-typed folder

dc175cd

Updated Readme

5239e4e

Updated Readme with following: 1. Installation instructions 2. APIs in AEPOptimize module

Added public class documentation

2de922e

Added documentation on following public classes: - DecisionScope - Offer - Proposition

Updated the comments for DecisionScope

9087805

Merge branch 'optimize' of github.com:adobe/aepsdk-react-native into …

bdda743

…optimize Merge the upstream

Merge staging branch and resolve the merge conflicts.

a993441

Fix compilation issues.

6396e79

Improved the UI: Improve the List view showing all the Offers.

db890e4

Implemented Offer displayed interaction in sample app.

0330b23

Added typescript definition file and Unit tests.

6a2bf3d

Changes in Offer.js to fix the broken Offer.display() and Offer.tappe…

e3e269b

…d() calls

Fixed an issue in getting fetched propositions.

f93e5ab

Updated the public class definitions in Readme

4e54868

Updated installation instructions

feb14f8

fix: updates hoisting

3f73a64

dsoffiantini force-pushed the optimize branch from bdb04b9 to 3f73a64 Compare June 22, 2022 19:51

dsoffiantini added 5 commits June 22, 2022 14:01

fix:revert gradle versions

e3bc55e

fix: update copyrights

743a007

Merge branch 'optimize' of https://github.com/adobe/aepsdk-react-native…

60b54d5

… into optimize

fix: bad merge on workspaces

15aef6b

feat: change optimize to async await

0be24c5

cacheung reviewed Jun 22, 2022

View reviewed changes

dsoffiantini added 4 commits June 22, 2022 16:41

docs: update docs to be more accurate

0fa3863

version: bump optimize to beta

c2906fa

version: bump messaging version, add readme badges

456f127

docs: update iam docs

c41f9ed

cacheung reviewed Jun 24, 2022

View reviewed changes

yangyansong-adbe approved these changes Jun 24, 2022

View reviewed changes

Merge branch 'staging' of https://github.com/adobe/aepsdk-react-native …

bef71cb

…into optimize

dsoffiantini force-pushed the optimize branch from 7f6cb6c to bef71cb Compare June 29, 2022 16:07

Merge branch 'staging' of https://github.com/adobe/aepsdk-react-native …

ac8d602

…into optimize

dsoffiantini force-pushed the optimize branch from 4e207be to ac8d602 Compare June 29, 2022 17:50

cacheung reviewed Jul 16, 2022

View reviewed changes

dsoffiantini added 5 commits July 18, 2022 13:22

version: revert messaging version

5890a82

Merge branch 'staging' of https://github.com/adobe/aepsdk-react-native …

97f9535

…into optimize

fix: remove snapshot for android

4d556c1

docs: update messaging docs

6a2f7dd

docs: messaging docs formatting

90db378

dsoffiantini force-pushed the optimize branch from fcca8dd to 90db378 Compare July 18, 2022 21:18

cacheung approved these changes Jul 18, 2022

View reviewed changes

dsoffiantini merged commit 64bdeb2 into staging Jul 18, 2022

		@@ -1,7 +1,7 @@

		# React Native Adobe Experience Platform Messaging Extension

AJO Optimize RN Package #177

AJO Optimize RN Package #177

Uh oh!

Conversation

dsoffiantini commented May 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Motivation and Context

How Has This Been Tested?

Types of changes

Checklist:

Uh oh!

cacheung left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cacheung left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yangyansong-adbe commented Jun 24, 2022

Uh oh!

cacheung commented Jun 24, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cacheung left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

dsoffiantini commented May 10, 2022 •

edited

Loading