Add Arraylist support in WriteableArray #145
Conversation
Add Arraylist support in WriteableArray
| } else if (value instanceof String) { | ||
| writableArr.pushString((String) value); | ||
| } else if (value instanceof Map) { | ||
| writableArr.pushMap(RCTAEPEdgeMapUtil.toWritableMap((Map<String, Object>) value)); |
There was a problem hiding this comment.
we should add the check for instanceof ArrayList to L105 and L78 too
There was a problem hiding this comment.
Should we use Interface instead of concrete class here? (change it to value instanceof List ?)
There was a problem hiding this comment.
Tested with List and it also works. Seems like Changing to List is better?
Add ArrayList check for more locations.
|
@yangyansong-adbe @emdobrin Do we need to add ArrayList check for other extensions if they are using ArrayUtil? |
|
@cacheung can you check why CI is not triggered for this PR? |
@cacheung Yes, I think we need to update this utility method in other extensions. |
Change checking the instanceof List instead of the ArrayList
CI is working now after @yangyansong-adbe enabled the setting for running CI for each PR. |
3 participants
Add Arraylist support in WriteableArray for Android.
If response payload has arraylist in it, it can be extracted now.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: