Update recoverable error codes #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinlind
reviewed
Oct 17, 2024
Contributor
kevinlind
left a comment
kevinlind
left a comment
There was a problem hiding this comment.
Looks good. A few minor comments plus the formatting needs fixing.
code/edge/src/main/java/com/adobe/marketing/mobile/EdgeNetworkService.java
Outdated
Show resolved
Hide resolved
code/edge/src/test/java/com/adobe/marketing/mobile/EdgeNetworkServiceTest.java
Outdated
Show resolved
Hide resolved
code/edge/src/test/java/com/adobe/marketing/mobile/EdgeNetworkServiceTest.java
Outdated
Show resolved
Hide resolved
kevinlind
approved these changes
Oct 17, 2024
timkimadobe
added a commit
to timkimadobe/aepsdk-edge-android
that referenced
this pull request
Nov 20, 2024
This reverts commit 4085495.
10 tasks
timkimadobe
pushed a commit
to timkimadobe/aepsdk-edge-android
that referenced
this pull request
Nov 20, 2024
* add 507 error code as recoverable, handle negative retry-after, tests * minor fix - comment * Fix format of EdgeNetworkService and tests * minor text updates * fix network mock after rebase with dev --------- Co-authored-by: Kevin Lind <[email protected]>
10 tasks
timkimadobe
added a commit
that referenced
this pull request
Nov 20, 2024
timkimadobe
pushed a commit
to timkimadobe/aepsdk-edge-android
that referenced
this pull request
Nov 20, 2024
* add 507 error code as recoverable, handle negative retry-after, tests * minor fix - comment * Fix format of EdgeNetworkService and tests * minor text updates * fix network mock after rebase with dev --------- Co-authored-by: Kevin Lind <[email protected]>
10 tasks
timkimadobe
added a commit
that referenced
this pull request
Feb 25, 2025
* Update recoverable error codes (#170) * add 507 error code as recoverable, handle negative retry-after, tests * minor fix - comment * Fix format of EdgeNetworkService and tests * minor text updates * fix network mock after rebase with dev --------- Co-authored-by: Kevin Lind <[email protected]> * Add exclusion for Edge back for Edge Consent dependency * Use $mavenEdgeConsentVersion instead of hardcoded value --------- Co-authored-by: Emilia Dobrin <[email protected]> Co-authored-by: Kevin Lind <[email protected]>
This was referenced Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: