Skip to content

Fix type annotation in adafruit_bus_device.SPIDevice.__init__() #6814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2022
Merged

Fix type annotation in adafruit_bus_device.SPIDevice.__init__() #6814

merged 1 commit into from
Aug 25, 2022

Conversation

@tekktrik
Copy link
Member

@tekktrik tekktrik commented Aug 25, 2022

Fixes #6813

microdev1
microdev1 approved these changes Aug 25, 2022
View reviewed changes
Copy link
Collaborator

@microdev1 microdev1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @tekktrik.

@microdev1 microdev1 added the bug label Aug 25, 2022
@microdev1 microdev1 merged commit 073fc9d into adafruit:main Aug 25, 2022
@tekktrik tekktrik deleted the doc/fix-typing branch May 31, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@microdev1 microdev1 microdev1 approved these changes

Assignees

No one assigned

Labels

bug documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Type annotation wrong for adafruit_bus_device.SPIDevice

2 participants

@tekktrik @microdev1