Fix handling of zero-length pulseout pulse #6798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[I updated the initial comment to have the special syntax for auto-closing the related issue] |
jepler
previously requested changes
Aug 23, 2022
reorder the tests for zero-length
dhalbert
approved these changes
Aug 25, 2022
Collaborator
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
This looks good to me now -- thanks! Will merge and backport to 7.3.x.
dhalbert
added a commit
that referenced
this pull request
Aug 25, 2022
7.3.x #6798 backport (zero-length pulse Pulseout fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting a zero-length pulse in pulseout would mean on an NRF board that the interrupt timer would never fire; thus hanging the program. This patch will bypass and ignore any pulses with a length of 0.
Closes #6735.