spresense: update SDK to 2.2.0 #5069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Collaborator
Yes, thank you. I forgot to update the submodules when I switched to this branch. Force-pushed a fix. |
Collaborator
|
It appears that sometimes this runs with |
jepler
added a commit
to jepler/circuitpython
that referenced
this pull request
Jul 27, 2021
@dhalbert noticed that if a fork was called `micropython`, the existing check could fail during CI because it will be cloned into a directory also called `micropython`. Instead of hardcoding a range of strings that are OK as top directories, find the location of the top directory relative to the script. This will be conflicty after adafruit#5069 is merged, but it should be easy to fix.
dhalbert
approved these changes
Jul 27, 2021
Collaborator
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
@kamtom480 Thanks for this quick fix.
@jepler Thanks for spotting the issues in my commits.
jepler
added a commit
to jepler/circuitpython
that referenced
this pull request
Jul 27, 2021
@dhalbert noticed that if a fork was called `micropython`, the existing check could fail during CI because it will be cloned into a directory also called `micropython`. Instead of hardcoding a range of strings that are OK as top directories, find the location of the top directory relative to the script. This will be conflicty after adafruit#5069 is merged, but it should be easy to fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Spresense SDK to version 2.2.0.