Add new board BastBLE #3662
Merged
Add new board BastBLE #3662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
requested changes
Nov 9, 2020
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
Please follow up when the CI fails. Thanks! I don't see any other potential issues.
Member
|
I suggest installing pre-commit locally to test more rapidly: https://pre-commit.com/#installation |
Member
|
The bastble build is broken. Looks like it needs a function name updated: https://github.com/adafruit/circuitpython/pull/3662/checks?check_run_id=1410247014 |
|
@tannewt ready, thanks! |
tannewt
approved these changes
Dec 22, 2020
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
Looks good! One comment that you can make a follow up PR for if you like.
| { MP_ROM_QSTR(MP_QSTR_AREF), MP_ROM_PTR(&pin_P0_31) }, | ||
|
|
||
| // voltage sense battery | ||
| { MP_ROM_QSTR(MP_QSTR_VBAT), MP_ROM_PTR(&pin_P0_26) }, |
Member
There was a problem hiding this comment.
Note, most boards name this pin VOLTAGE_MONITOR or BATTERY.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I would like to be able to add this new BastBLE card from electronic cats to your repository.
I await your feedback and response.
I thank you in advance.
Best regards