Add vectorio: for drawing shapes #2873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vectorio builds on m4 express feather
Concrete shapes are composed into a VectorShape which is put into a displayio Group for display.
VectorShape provides transpose and x/y positioning for shape implementations.
Included Shapes:
* Circle
- A radius; Circle is positioned at its axis in the VectorShape.
- You can freely modify the radius to grow and shrink the circle in-place.
* Polygon
- An ordered list of points.
- Beteween each successive point an edge is inferred. A final edge closing the shape is inferred between the last
point and the first point.
- You can modify the points in a Polygon. The points' coordinate system is relative to (0, 0) so if you'd like a
top-center justified 10x20 rectangle you can do points [(-5, 0), (5, 0), (5, 20), (0, 20)] and your VectorShape
x and y properties will position the rectangle relative to its top center point
* Rectangle
A width and a height.
Rather than maintain a transform per-shape, we'll just use whatever settings are on the Display. Currently only transpose is done.
VectorShape now just uses the Group's and Display's absolute transforms.
VectorShape tells the Group to redraw whatever it left behind when it is removed now.
* Fix drawing 1 pixel too large * Need to pad dirty area to ensure removed shapes are fully removed
tannewt
reviewed
May 11, 2020
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
A few questions. Lots for my brain to process. Thanks for this! It'll be a huge benefit for folks. Line might be nice to have too.
|
I just wanted to chime in with some words of encouragement. Thanks @WarriorOfWire! I'm excited to see this merged :) |
tannewt
previously approved these changes
May 12, 2020
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
Thanks for this! I'll merge after I resolve the translation updates for you.
Member
|
Oops, looks like I don't have permission to change your branch. Here is a PR into your branch: kvc0#1 |
Merge in master
arturo182
reviewed
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vectorio builds on m4 express feather
Concrete shapes are composed into a VectorShape which is put into a displayio Group for display.
VectorShape provides transpose and x/y positioning for shape implementations.
Included Shapes:
Circle
Polygon
point and the first point.
top-center justified 10x20 rectangle you can do points [(-5, 0), (5, 0), (5, 20), (-5, 20)] and your VectorShape
x and y properties will position the rectangle relative to its top center point
Rectangle
A width and a height.