Throw a NotImplementedError for time functions on boards without long ints #2871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update fork
… ints Fix for Issue #2812. Instead of reporting a missing attribute for functions such as time.time() and time.mktime(); platforms that do not have long integer support will raise a NotImplementedError
update fork
tannewt
requested changes
May 11, 2020
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
Thanks for this! You'll need to merge again for translations and then please make sure your protomatter submodule doesn't change. This PR shouldn't change it.
Adding a message for the fix of issue #2812
tannewt
approved these changes
May 12, 2020
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
Thanks for the merge! Looks great.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #2812. Raise a NotImplementedError instead of an AttributeError for a missing function for time functions such as time.time() and time.mktime() on platforms that do not support long integers.