NRF: Minor Simmel fixes #2869
Merged
NRF: Minor Simmel fixes #2869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I've tried to rerun the checks. It looks like some of the larger translations were failing for the simmel build. |
Author
|
Which are failing? |
Member
|
Looks like de_DE, pl, fr, it_IT, es, ko, fil, and zh_Latn_pinyin: https://github.com/adafruit/circuitpython/pull/2869/checks?check_run_id=657239982 |
The CSn pin is pin 6 on bank 1, not bank 0. Signed-off-by: Sean Cross <[email protected]>
This adds AES support to simmel. Signed-off-by: Sean Cross <[email protected]>
SPIM3 is faster than all other SPI blocks, and is capable of generating a 32 MHz clock. However, it cannot be used at the same time as the BLE radio without dedicating an additional 8 kB of RAM to it. Therefore, some boards may want to disable this. Support pre-defining NRFX_SPIM3_ENABLED on the command line to disable it on some bords. Signed-off-by: Sean Cross <[email protected]>
Disable the SPIM3 controller to avoid needing to dedicate 8 kB to the SPIM3 block. Signed-off-by: Sean Cross <[email protected]>
The flash filesystem must be reduced in order to allow the current build to fit. Signed-off-by: Sean Cross <[email protected]>
Author
|
Thanks, I didn't notice that among the other build failures. I've reduced the flash filesystem by one block. Incidentally, I opened up #2884 which I've run into several times while figuring the optimal internal filesystem size. We'll probably enable SPI flash at some point soon, but for now I'll be doing the flash filesystem dance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patchset includes several minor fixes to Simmel fixes:
CIRCUITPY_AESIOon Simmel