Parameterize flash storage layout for atmel-samd and nrf #2371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalbert
commented
Dec 11, 2019
dhalbert
commented
Dec 11, 2019
tannewt
requested changes
Dec 11, 2019
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
A few minor things. Overall this looks like an awesome improvement! Thanks!
Collaborator
Author
|
@tannewt ok, ready for re-review |
tannewt
approved these changes
Dec 12, 2019
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
Ok, looks good! Lets make sure and warn folks to back up their files on non-Express boards with the next release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use preprocessor macros to define the size and position of flash regions. This reduces all the different linker
.ldfiles to a single template file,boards/common.template.ld.The needed preprocessor values are made available in
ports/*/ld_defines.c. . At build time, that file is run through the C preprocessor, generatingld_defines.pp. Thentools/gen_ld_files.pyreadsld_defines.pp,common.template.ld, and generatescommon.ldin the board build directory.(There is provision for more than one template file, but so far, we only need one).
I also did a lot of cleanup and refactoring of the
mpconfigboard.mkfiles, moving a number of definitions to common places.This is working for
atmel-samdandnrf.stm32f4andcxd56remain to be done.Testing: I built and tested various
atmel-samdboards, and they seem to work. I built somenrfboards, and tested the CPB builds with the central/peripheral demo.pca10059 doesn't work properly, but it didn't work before either (see #2339). We can debug that separately.
This is preparatory to storing bonding information on nrf.