Skip to content

Conversation

@dhalbert
Copy link
Collaborator

  • Circuit Playground Bluefruit does not have a 32kHz crystal on board. This is quite unusual, and the nRF clock code assumed there would be one. Caused BLE failures and other timing-related issues.
  • There is not a status neopixel on this board, as with CPX: first neopixel was getting reset with status colors.
  • Fixed typo in an unrelated error string.

Thanks @ladyada and @hathach.

@dhalbert dhalbert requested review from ladyada and tannewt August 22, 2019 05:11
@dhalbert dhalbert requested review from jepler and removed request for ladyada August 22, 2019 05:41
@dhalbert
Copy link
Collaborator Author

@bmeisels and @jepler Apologies: I encountered exactly the same issue with the Circuit Playground Bluefruit and didn't realize there was a PR approved 9 hours beforehand. I wrote essentially the same PR, but with just #if and no inline routine. This is more the style we use now. Also fixed a couple of other things at the same time.

@dhalbert
Copy link
Collaborator Author

Added some #pragma message () temporarily to check that the correct #if BOARD_HAS_32KHZ_CRYSTAL conditional arms were being used.

I should not try to complete a PR after midnight.

Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good

@dhalbert dhalbert merged commit 18f441a into adafruit:master Aug 22, 2019
@dhalbert dhalbert deleted the no-32khz-xtal branch August 22, 2019 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants