Offline qmc5883p (after mlx) - with added Vector value support #810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyeth
commented
Sep 16, 2025
| * please support Adafruit and open-source hardware by purchasing | ||
| * products from Adafruit! | ||
| * | ||
| * Copyright (c) Tyeth Gundry 2024 for Adafruit Industries. |
|
This boot loops at creating SD log file on pico. Fine on S3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the QMC5883P which is the first vector based sensor to be added.
WS already has the type recognised, but not implemented in most places, so there is one commit adding that.
While I was there it made sense to add the other vector based types, as I've been keen to do other accelerometers, not just magnetometers. As it stands I haven't got an RGBA sensor that comes to mind so I've left colour out for now.
I also fought clang-format again and finally triumphed. The implicit rules varied between CI and windows, and I'd previously attempted to produce a rule file to resolve it, but was a battle I lost on two occasions. This time Victory!
There's now a ci-wippersnapper-show-config branch in ci-arduino which adds the --show-config flag to run-clang-format.py which I tested with and then reverted from the offline build script.