update ukulele for ulab renames #1675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
See https://forums.adafruit.com/viewtopic.php?f=24&t=172976 for a user who is experiencing trouble with the code. |
jepler
approved these changes
Aug 3, 2021
Contributor
jepler
left a comment
jepler
left a comment
There was a problem hiding this comment.
Seems plausible to me. I invited a user from the forum to test & give feedback but no need to hold off merging this for their response.
Collaborator
|
Guide appears corrected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes update the code to use the latest version of ulab with the renaming that has occurred.
There was 1 instance of usage of
argmaxthat needed updating on this page: https://learn.adafruit.com/light-up-reactive-ukulele/software and I've changed it to match the new code from this PR.I do not have the specific hardware required for testing the full project. But I did run the specific lines of code that were changed in REPL to verify that they work as intended.