change read_region() #1071
Merged
change read_region() #1071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add time.sleep(.3) delays and break(s) to exit loop upon touch. (my opinion) more responsive game. do not have to wait for timer to expire (30 seconds) between touches.
remove 'debug=false' in decoder.decode_bits(pulses). It would crash the code as debug is not used.
Contributor
Author
|
Added a commit and change for cpx_hunter.py file. debug was removed from adafruit_irremote.py in: adafruit/Adafruit_CircuitPython_IRRemote#27. The debug=False was causing code to fail. |
update fork from adafruit
update liltux branch with master
Contributor
|
@ladyada Sorry, just coming across this. Both changes look good. Tested first one and it works. Second one looks like simple update to match a breaking change. |
caternuson
approved these changes
Apr 29, 2020
Member
|
np merge once it passes :) |
Contributor
|
@liltux Thanks for the updates! |
Contributor
Author
|
@everyone_adafruit you all are awesome, I love the circuit playground boards. I just came across some things while working on projects to do with my kiddos. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add time.sleep(.3) delays and break(s) to exit loop upon touch. (my opinion) more responsive game. do not have to wait for timer to expire (30 seconds) between touches.