Skip to content

Linted #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2021
Merged

Linted #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions adafruit_turtle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,7 +715,7 @@ def clearstamps(self, n=None):

"""
i = 1
for sid in self._stamps:
for sid in self._stamps: # pylint: disable=consider-using-dict-items
if self._stamps[sid] is not None:
self.clearstamp(sid)
if n is not None and i >= n:
Expand Down Expand Up @@ -967,8 +967,8 @@ def bgpic(self, picname=None):
self._bg_pic = None
self._bg_pic_filename = ""
else:
self._bg_pic = open(picname, "rb")
odb = displayio.OnDiskBitmap(self._bg_pic)
with open(picname, "rb") as self._bg_pic:
odb = displayio.OnDiskBitmap(self._bg_pic)
self._odb_tilegrid = displayio.TileGrid(
odb, pixel_shader=displayio.ColorConverter()
)
Expand Down Expand Up @@ -1077,7 +1077,9 @@ def changeturtle(self, source=None, dimensions=(12, 12)):
self._turtle_odb_file = None
self._turtle_odb_use -= 1
self._turtle_pic = None
self._turtle_odb_file = open(source, "rb")
self._turtle_odb_file = open( # pylint: disable=consider-using-with
source, "rb"
)
try:
self._turtle_odb = displayio.OnDiskBitmap(self._turtle_odb_file)
except:
Expand Down