Skip to content

Switch to write and readinto #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2019
Merged

Switch to write and readinto #8

merged 1 commit into from
Sep 3, 2019

Conversation

@caternuson
Copy link
Contributor

@caternuson caternuson commented Aug 29, 2019

Fix for #7 so it will work on RPI:

pi@pizerow:~$ python3 vl6180x_simpletest.py 
Range: 125mm
Light (1x gain): 248.0lux
Range: 102mm
Light (1x gain): 62.4lux
Range: 109mm
Light (1x gain): 34.88lux

and still works on CP:

Adafruit CircuitPython 4.1.0 on 2019-08-02; Adafruit Metro M4 Airlift Lite with samd51j19
>>> import vl6180x_simpletest
Range: 255mm
Light (1x gain): 366.08lux
Range: 255mm
Light (1x gain): 363.84lux
Range: 132mm
Light (1x gain): 16.0lux

@ladyada ladyada requested a review from tannewt August 29, 2019 21:47
@ladyada ladyada mentioned this pull request Sep 2, 2019
Closed
tannewt
tannewt approved these changes Sep 3, 2019
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@tannewt tannewt merged commit 9929cd3 into adafruit:master Sep 3, 2019
@ladyada
Copy link
Member

ladyada commented Sep 3, 2019

@caternuson plz bump

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Sep 4, 2019
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@62c4c36)
0b96e45 
Updating https://github.com/adafruit/Adafruit_CircuitPython_LIDARLite to 1.1.2 from 1.1.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_LIDARLite#5 from dastels/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_VL6180X to 1.1.4 from 1.1.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_VL6180X#8 from caternuson/iss7

Updating https://github.com/adafruit/Adafruit_CircuitPython_BitmapSaver to 1.0.1 from 1.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_BitmapSaver#3 from dastels/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_BitmapSaver, Adafruit_CircuitPython_LIFX, Adafruit_CircuitPython_PYOA, Adafruit_CircuitPython_turtle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tannewt tannewt tannewt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@caternuson @ladyada @tannewt