Skip to content

Add an Invert option #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 2, 2019
Merged

Add an Invert option #9

merged 2 commits into from
Aug 2, 2019

Conversation

@Septolum
Copy link
Contributor

@Septolum Septolum commented Aug 2, 2019

No description provided.

@makermelissa makermelissa requested a review from tannewt August 2, 2019 15:45
@makermelissa
Copy link
Collaborator

makermelissa commented Aug 2, 2019

I'm not sure if there are plans to add this into displayio itself already, so I've added Scott as a reviewer.

tannewt
tannewt approved these changes Aug 2, 2019
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how I'd do it since the need for inversion depends on how the screen is connected to the controller IC. Thanks @Septolum!

@tannewt tannewt merged commit aa6c6f2 into adafruit:master Aug 2, 2019
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Aug 3, 2019
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@fc4488a)
b90b5b9 
Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7735R to 1.1.1 from 1.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_ST7735R#10 from makermelissa/master
  > Merge pull request adafruit/Adafruit_CircuitPython_ST7735R#9 from Septolum/master
  > Merge pull request adafruit/Adafruit_CircuitPython_ST7735R#8 from makermelissa/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tannewt tannewt tannewt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Septolum @makermelissa @tannewt