save last_rssi reading after packet received #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentru
approved these changes
Mar 5, 2020
Member
brentru
left a comment
brentru
left a comment
There was a problem hiding this comment.
I like this implementation, are you going to add it to RFM9x?
Contributor
Author
|
@brentru I'll look at rfm9x -- it handles RSSI a bit differently but we should make it consistent. |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Mar 6, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_IL91874 to 1.0.2 from 1.0.1: > build.yml: move pylint, black, and Sphinx installs to each repo; add description to 'actions-ci/install.sh' > Merge pull request adafruit/Adafruit_CircuitPython_IL91874#6 from danlove99/master Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM6DS to 2.0.2 from 2.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_LSM6DS#8 from ladyada/master > build.yml: move pylint, black, and Sphinx installs to each repo; add description to 'actions-ci/install.sh' > Merge pull request adafruit/Adafruit_CircuitPython_LSM6DS#7 from ladyada/master Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 3.1.11 from 3.1.10: > build.yml: move pylint, black, and Sphinx installs to each repo; add description to 'actions-ci/install.sh' > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#66 from ladyada/master Updating https://github.com/adafruit/Adafruit_CircuitPython_RFM69 to 1.4.0 from 1.3.1: > Merge pull request adafruit/Adafruit_CircuitPython_RFM69#23 from jerryneedell/jerryn_rssi Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_BroadcastNet to 0.8.0 from df145c9: < Merge pull request adafruit/Adafruit_CircuitPython_BLE_BroadcastNet#3 from tannewt/update_doc Updating https://github.com/adafruit/Adafruit_CircuitPython_Debug_I2C to 1.0.1 from 4e7463b: < build.yml: move pylint, black, and Sphinx installs to each repo; add description to 'actions-ci/install.sh' Updating https://github.com/adafruit/Adafruit_CircuitPython_ProgressBar to 1.1.1 from 73870c4: < build.yml: move pylint, black, and Sphinx installs to each repo; add description to 'actions-ci/install.sh' Updating https://github.com/adafruit/Adafruit_CircuitPython_WSGI to 1.0.0 from e7835a7: < build.yml: move pylint, black, and Sphinx installs to each repo; add description to 'actions-ci/install.sh' Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_BLE_BroadcastNet, Adafruit_CircuitPython_Debug_I2C, Adafruit_CircuitPython_ProgressBar, Adafruit_CircuitPython_WSGI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #22
the rssi property reads the current state of RSSI register and it may not be meaningful if not read immediately after the packet it received. This PR adds a last_rssi attribute which holds the RSSI reading from the last packet received.
Tested on Raspberry Pi with RFM69 Bonnet