Adding PyPortal and Pew Pew M4 support #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # adafruit_pybadger/__init__.py
Contributor
Author
|
During the weekly meeting I mentioned a possible issue with this PR. I was mistakenly thinking that this library was using adafruit_imageload but now that I've had a chance to take a closer look I see that this is not the case. So there are no outstanding issues with this that I am aware of. |
kattni
approved these changes
Jun 24, 2020
Contributor
kattni
left a comment
kattni
left a comment
There was a problem hiding this comment.
Tested with PyPortal. Thanks for adding this support!
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jun 25, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_BluefruitConnect to 1.1.3 from 1.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_BluefruitConnect#22 from dhalbert/pypi-packages Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.7.3 from 2.7.2: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#53 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_PyBadger to 3.0.0 from 2.2.2: > Merge pull request adafruit/Adafruit_CircuitPython_PyBadger#34 from FoamyGuy/adding_pewpewm4_support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add support for the Pew Pew M4 device as well as an example script. This also contains the changes to add support for PyPortal from #33.
While making this change I refactored the neopixel usage out of base and into the device specific modules. The Pew Pew M4 does not have an onboard neopixel, so the new module for it lacks
import neopixeland setspixels = _unsupported.I tested the changes with the respective simpletest scripts modified to make use of
pixelson: