set_text_color: check if label is None before assigning value #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure label of text is set before changing its color property. Fixes: adafruit#29
Contributor
Author
|
Hello again @makermelissa . ;) I think we may need this change as well in order to have Thanks, -- flaviof |
makermelissa
approved these changes
Apr 12, 2021
Collaborator
makermelissa
left a comment
makermelissa
left a comment
There was a problem hiding this comment.
Thanks for finding this! Looks great.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Apr 13, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 5.1.7 from 5.1.6: > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#109 from Neradoc/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_MatrixPortal to 2.2.3 from 2.2.2: > Merge pull request adafruit/Adafruit_CircuitPython_MatrixPortal#73 from flavio-fernandes/fix.issue.72 Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 1.5.2 from 1.5.1: > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#30 from flavio-fernandes/fix.issue.29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure label of text is set before changing its color property.
Fixes: #29