fix samd51 check for 10.x #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalbert
approved these changes
Sep 5, 2025
adafruit-adabot
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Sep 6, 2025
Updating https://github.com/adafruit/Adafruit_CircuitPython_MatrixPortal to 3.2.8 from 3.2.7: > Merge pull request adafruit/Adafruit_CircuitPython_MatrixPortal#104 from FoamyGuy/update_samd51_check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #103
The only 2 other instances of
os.uname().sysnamethat I could find in the bundle were also in this library inside ofmatrix.pyand they already useinlogic with strings that I verified still works properly under 10.x. https://github.com/adafruit/Adafruit_CircuitPython_MatrixPortal/blob/main/adafruit_matrixportal/matrix.py#L105This issue was originally noticed here: adafruit/Adafruit_CircuitPython_PortalBase#115
And I tested these changes successfully with the reproducer from that thread.