Remove stop kwarg and use write_then_readinto. #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kattni
approved these changes
Aug 27, 2019
Contributor
kattni
left a comment
kattni
left a comment
There was a problem hiding this comment.
Tested successfully with Metro M4 and character LCD shield (MCP23017).
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Aug 27, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_DS1307 to 2.0.0 from 1.3.3: > Merge pull request adafruit/Adafruit_CircuitPython_DS1307#11 from tannewt/remove_stop Updating https://github.com/adafruit/Adafruit_CircuitPython_L3GD20 to 2.1.0 from 2.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_L3GD20#13 from tannewt/remove_stop Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP230xx to 2.2.0 from 2.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_MCP230xx#16 from tannewt/remove_stop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See adafruit/circuitpython#2082 for details.