Add font customization #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekktrik
requested changes
Jul 23, 2023
Member
tekktrik
left a comment
tekktrik
left a comment
There was a problem hiding this comment.
One small request, but otherwise looks ready to go!
adafruit_max7219/matrices.py
Outdated
| :param int xpos: x position of LED in matrix | ||
| :param int ypos: y position of LED in matrix | ||
| :param int bit_value: > 1 sets the text, otherwise resets | ||
| :param str font_name: path to binary font file (default: "font5x8.bin") |
Member
There was a problem hiding this comment.
My understanding based on looking how FrameBuffer.text() works is that once the font is set for the Matrix8x8 it can't be changed, and it is set on the first call to this method. It may be helpful then to add that fact here to prevent future confusion.
Member
|
I am going to unlink the issue though, since that seems to be more of a problem with the default font not being included rather than the ability to alter it. |
FoamyGuy
approved these changes
Sep 5, 2023
Contributor
FoamyGuy
left a comment
FoamyGuy
left a comment
There was a problem hiding this comment.
I added a note about the font not being able to be changed after the first time.
This looks good to me now.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Sep 5, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX7219 to 1.5.12 from 1.5.11: > Merge pull request adafruit/Adafruit_CircuitPython_MAX7219#47 from jerr0328/fix-36 Updating https://github.com/adafruit/Adafruit_CircuitPython_turtle to 2.2.16 from 2.2.15: > Merge pull request adafruit/Adafruit_CircuitPython_turtle#35 from rrahkola/dev/add_type_annotations Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The font is bundled in the framebuf dependency's examples (see: adafruit/Adafruit_CircuitPython_framebuf#11)
I don't have this board to test with, just contributing from Europython 2023 Sprints 👋