Skip to content

Adding adafruit-circuitpython-framebuf #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 4, 2019
Merged

Adding adafruit-circuitpython-framebuf #18

merged 2 commits into from
Feb 4, 2019

Conversation

@Tasm-Devil
Copy link

@Tasm-Devil Tasm-Devil commented Feb 2, 2019

No description provided.

Pascal Deneaux added 2 commits February 2, 2019 20:15
Update requirements.txt
b665a53 
Adding adafruit-circuitpython-framebuf
adafruit_framebuf
9e95368
@ladyada
Copy link
Member

ladyada commented Feb 2, 2019

@Tasm-Devil awesome, thank you :) did you try it with hardware?

@Tasm-Devil
Copy link
Author

Tasm-Devil commented Feb 2, 2019

Yes. Tried it on an nrf52840 with CP4 and it works.

@ladyada
Copy link
Member

ladyada commented Feb 3, 2019

its not working because we dont have scroll in adafruit_framebuf...not sure when we'll get to implementing it :(

@Tasm-Devil
Copy link
Author

Tasm-Devil commented Feb 3, 2019

I (re)implemented the scroll method to adafruit_framebuff. Now it works. I tested it.

@ladyada
Copy link
Member

ladyada commented Feb 3, 2019

huzzzah - i did a release so in a bit ill rerun travis!

@ladyada
Copy link
Member

ladyada commented Feb 3, 2019

hmm its still failing, but it could be a pylint bug - did you try the simpletest.py example?

@Tasm-Devil
Copy link
Author

Tasm-Devil commented Feb 3, 2019

I tested max7219_simpletest.py and framebuf_simpletest.py.
Both work with no problems on the nrf52840.
I have no Linux-Circuitpython installation. So I can't test this one.

It sounds like Travis is using the previous Version of adafruit-circuitpython-framebuf which has a scroll-method with no arguments. That's where the Too many positional arguments for method call (too-many-function-args) Error comes from.

@ladyada ladyada merged commit ad3fbb3 into adafruit:master Feb 4, 2019
@ladyada
Copy link
Member

ladyada commented Feb 4, 2019

weird - it was another error --- but now it works :)

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Feb 4, 2019
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@216e3e8)
bb2ffcd 
Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX7219 to 1.2.0 from 1.1.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX7219#18 from Tasm-Devil/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_FeatherWing to 1.2.0 from 1.1.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#24 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_framebuf to 1.0.3 from 1.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_framebuf#13 from Tasm-Devil/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Tasm-Devil @ladyada